Merge branch 'feature/73' into develop

Closes #73
Closes #68
Closes #67

Author: heiglandreas

CHANGELOG.md

@@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file, in reverse
 
 - [#64](https://github.com/zendframework/zend-ldap/pull/64) Adds support for SASL-Bind - Thanks to @mbaynton
 - [#66](https://github.com/zendframework/zend-ldap/pull/66) Adds support for automatic reconnection - Thanks to @mbaynton
+- [#73](https://github.com/zendframework/zend-ldap/pull/73) Adds support for modifying attributes - Thanks to @glimac and @mbaynton
 
 ### Deprecated
 

src/Ldap.php

@@ -1538,6 +1538,45 @@ public function addAttributes($dn, array $attributes, $allowEmptyAttributes = fa
         return $this;
     }
 
+    /**
+     * Update one or more attributes to the specified dn
+     *
+     * @param  string|Dn $dn
+     * @param  array     $attributes
+     * @param bool       $allowEmptyAttributes
+     * @return Ldap Provides a fluid interface
+     * @throws LdapException
+     */
+    public function updateAttributes($dn, array $attributes, $allowEmptyAttributes = false)
+    {
+        // Safety-flap: Check whether there are empty arrays that would cause
+        // complete removal of entries without the emptyAll flag.
+        if ($allowEmptyAttributes !== true) {
+            foreach ($attributes as $key => $value) {
+                if (empty($value)) {
+                    unset($attributes[$key]);
+                }
+            }
+        }
+
+        if ($dn instanceof Dn) {
+            $dn = $dn->toString();
+        }
+
+        do {
+            ErrorHandler::start(E_WARNING);
+            $entryUpdated = ldap_mod_replace($this->resource, $dn, $attributes);
+            ErrorHandler::stop();
+        } while ($entryUpdated === false && $this->shouldReconnect($this->resource));
+
+
+        if ($entryUpdated === false) {
+            throw new Exception\LdapException($this, 'updating attribute: ' . $dn);
+        }
+
+        return $this;
+    }
+
     /**
      * Delete single attributes from a LDAP-Node
      *

test/OfflineTest.php

@@ -225,4 +225,40 @@ public function testAddingAttributesFails()
         $ldap = new \Zend\Ldap\Ldap();
         $ldap->addAttributes('foo', ['bar']);
     }
+
+    /**
+     * @dataProvider removingAttributesProvider
+     */
+    public function testUpdatingAttributes(
+        $dn,
+        $attributes,
+        $allowEmptyAttributes,
+        $expectedDn,
+        $expectedAttributesToRemove
+    ) {
+        $ldap_mod_upd = $this->getFunctionMock('Zend\\Ldap', "ldap_mod_replace");
+        $ldap_mod_upd->expects($this->once())
+                     ->with(
+                         $this->isNull(),
+                         $this->equalTo($expectedDn),
+                         $this->equalTo($expectedAttributesToRemove)
+                     )
+                     ->willReturn(true);
+
+        $ldap = new \Zend\Ldap\Ldap();
+        $this->assertSame($ldap, $ldap->updateAttributes($dn, $attributes, $allowEmptyAttributes));
+    }
+
+    /**
+     * @expectedException \Zend\Ldap\Exception\LdapException
+     */
+    public function testUpdatingAttributesFails()
+    {
+        $ldap_mod_upd = $this->getFunctionMock('Zend\\Ldap', 'ldap_mod_replace');
+        $ldap_mod_upd->expects($this->once())
+                     ->willReturn(false);
+
+        $ldap = new \Zend\Ldap\Ldap();
+        $ldap->updateAttributes('foo', ['bar']);
+    }
 }