Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

PHP 7.3 issue with compact() in HeadLink.php #172

Closed
unicarevcs opened this issue Dec 6, 2018 · 2 comments
Closed

PHP 7.3 issue with compact() in HeadLink.php #172

unicarevcs opened this issue Dec 6, 2018 · 2 comments
Assignees
Milestone

Comments

@unicarevcs
Copy link

Under PHP 7.3 we see the following logged:
PHP Notice: compact(): Undefined variable: extras in src\Helper\HeadLink.php on line 413

A quick fix replaces lines 408-413 with:
$attributes = compact('rel', 'type', 'href', 'media', 'conditionalStylesheet');

if ($args && is_array($args[0])) {
$attributes['extras'] = array_shift($args);
}

@froschdesign
Copy link
Member

We already have a pull request (#170) for this problem and will be released with the next bugfix release (2.10.1).

@Ocramius Ocramius self-assigned this Dec 6, 2018
@Ocramius Ocramius added this to the 2.10.1 milestone Dec 6, 2018
@Ocramius
Copy link
Member

Ocramius commented Dec 6, 2018

Closing as duplicate

@Ocramius Ocramius closed this as completed Dec 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants