Skip to content

Commit 0e60b81

Browse files
committed
Move all testing docs to qa.php.net
The qa.php.net currently includes nice collection of information about tests and how to run them. Instead of maintaining two locations of this information, this patch removes the README.TESTING from the php-src repo. Patch for qa.php.net has been sent separately to that repo.
1 parent 78a8b0f commit 0e60b81

File tree

10 files changed

+13
-199
lines changed

10 files changed

+13
-199
lines changed

Diff for: CODING_STANDARDS

+1-1
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ Testing
251251
-------
252252

253253
1. Extensions should be well tested using *.phpt tests. Read about that
254-
in README.TESTING.
254+
at https://qa.php.net/write-test.php.
255255

256256
Documentation and Folding Hooks
257257
-------------------------------

Diff for: CONTRIBUTING.md

-3
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,6 @@ We love getting new tests! PHP is a huge project and improving code coverage is
5252
a huge win for every PHP user.
5353

5454
[Our QA site includes a page detailing how to write test cases.](http://qa.php.net/write-test.php)
55-
Please note that the section on submitting pull requests is outdated: in
56-
addition to the process listed there, you can also
57-
[submit pull requests](#pull-requests).
5855

5956
## Writing documentation
6057

Diff for: README.SUBMITTING_PATCH

+4-5
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,10 @@ work on "master".
138138

139139
Read CODING_STANDARDS before you start working.
140140

141-
After modifying the source see README.TESTING and
142-
http://qa.php.net/write-test.php for how to test. Submitting test
143-
scripts helps us to understand what functionality has changed. It is
144-
important for the stability and maintainability of PHP that tests are
145-
comprehensive.
141+
After modifying the source see https://qa.php.net/write-test.php for
142+
how to test. Submitting test scripts helps us to understand what
143+
functionality has changed. It is important for the stability and
144+
maintainability of PHP that tests are comprehensive.
146145

147146
After testing is finished, create a patch file using the command:
148147

Diff for: README.TESTING

-181
This file was deleted.

Diff for: README.md

+7
Original file line numberDiff line numberDiff line change
@@ -37,3 +37,10 @@ Guidelines for contributors
3737
- [README.GIT-RULES](/README.GIT-RULES)
3838
- [README.MAILINGLIST_RULES](/README.MAILINGLIST_RULES)
3939
- [README.RELEASE_PROCESS](/README.RELEASE_PROCESS)
40+
41+
## Testing
42+
43+
To run tests the `make test` is used after successful compilation of the sources.
44+
45+
See [Creating new test files](https://qa.php.net/write-test.php) chapter for more
46+
information about testing.

Diff for: ext/exif/tests/exif005.phpt

+1-3
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ output_handler=
77
zlib.output_compression=0
88
--FILE--
99
<?php
10-
/* Do not change this test it is a README.TESTING example.
11-
* test5.jpg is a 1*1 image that contains an Exif section with ifd = 00000009h
12-
*/
10+
// test5.jpg is a 1*1 image that contains an Exif section with ifd = 00000009h
1311
$image = exif_read_data(dirname(__FILE__).'/test5.jpg','',true,false);
1412
var_dump($image['IFD0']);
1513
?>

Diff for: ext/sodium/tests/installed.phpt

-3
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ echo "sodium extension is available";
1212
text in the --EXPECT-- section below for the tests
1313
to pass, differences between the output and the
1414
expected text are interpreted as failure
15-
16-
see php7/README.TESTING for further information on
17-
writing regression tests
1815
*/
1916
?>
2017
--EXPECT--

Diff for: ext/standard/tests/strings/str_shuffle.phpt

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
Testing str_shuffle.
33
--FILE--
44
<?php
5-
/* Do not change this test it is a README.TESTING example. */
65
$s = '123';
76
var_dump(str_shuffle($s));
87
var_dump($s);

Diff for: ext/standard/tests/strings/strings001.phpt

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
Test whether strstr() and strrchr() are binary safe.
33
--FILE--
44
<?php
5-
/* Do not change this test it is a README.TESTING example. */
65
$s = "alabala nica".chr(0)."turska panica";
76
var_dump(strstr($s, "nic"));
87
var_dump(strrchr($s," nic"));

Diff for: ext/standard/tests/strings/strtr.phpt

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
strtr() function
33
--FILE--
44
<?php
5-
/* Do not change this test it is a README.TESTING example. */
65
$trans = array("hello"=>"hi", "hi"=>"hello", "a"=>"A", "world"=>"planet");
76
var_dump(strtr("# hi all, I said hello world! #", $trans));
87
?>

0 commit comments

Comments
 (0)