fix: disable textmate bundle when JetBrains plugin is uninstalled (#918)

Author: ymc9

packages/ide/jetbrains/.idea/gradle.xml

@@ -5,7 +5,7 @@ plugins {
 }
 
 group = "dev.zenstack"
-version = "0.5.0"
+version = "1.6.0"
 
 repositories {
     mavenCentral()

packages/ide/jetbrains/.idea/vcs.xml

@@ -0,0 +1,28 @@
+package dev.zenstack
+
+import com.intellij.lang.javascript.service.JSLanguageServiceUtil
+import org.jetbrains.plugins.textmate.TextMateService
+import org.jetbrains.plugins.textmate.configuration.TextMateUserBundlesSettings
+
+class Utils {
+    companion object {
+        fun addTextMateBundle() {
+            println("Adding ZenStack textmate bundle")
+            val textMateBundle = JSLanguageServiceUtil.getPluginDirectory(javaClass, "res/zmodel.tmbundle")
+            TextMateUserBundlesSettings.instance?.addBundle(textMateBundle.path, "zmodel")
+            reloadTextMateBundles()
+        }
+
+        fun disableTextMateBundle() {
+            println("Disabling ZenStack textmate bundle")
+            val textMateBundle = JSLanguageServiceUtil.getPluginDirectory(javaClass, "res/zmodel.tmbundle")
+            TextMateUserBundlesSettings.instance?.disableBundle(textMateBundle.path)
+            reloadTextMateBundles()
+        }
+
+        private fun reloadTextMateBundles() {
+            val textMateService = TextMateService.getInstance();
+            textMateService.reloadEnabledBundles()
+        }
+    }
+}

packages/ide/jetbrains/build.gradle.kts

@@ -1,6 +1,5 @@
 package dev.zenstack.lsp
 
-import com.intellij.codeInsight.completion.CompletionParameters
 import com.intellij.execution.ExecutionException
 import com.intellij.execution.configurations.GeneralCommandLine
 import com.intellij.javascript.nodejs.interpreter.NodeCommandLineConfigurator
@@ -11,23 +10,17 @@ import com.intellij.lang.javascript.service.JSLanguageServiceUtil
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.vfs.VirtualFile
 import com.intellij.platform.lsp.api.ProjectWideLspServerDescriptor
-import com.intellij.platform.lsp.api.customization.LspCompletionSupport
 import com.intellij.platform.lsp.api.customization.LspFormattingSupport
-import org.jetbrains.plugins.textmate.configuration.TextMateUserBundlesSettings
-import org.jetbrains.plugins.textmate.TextMateService;
 import dev.zenstack.lang.ZModelFileType
+import dev.zenstack.Utils
 
 class ZenStackLspServerDescriptor(project: Project) : ProjectWideLspServerDescriptor(project, "ZenStack") {
 
     override fun isSupportedFile(file: VirtualFile) = file.fileType == ZModelFileType
 
     override fun createCommandLine(): GeneralCommandLine {
 
-        // install TextMate bundle
-        val textMateBundle = JSLanguageServiceUtil.getPluginDirectory(javaClass, "res/zmodel.tmbundle")
-        TextMateUserBundlesSettings.instance?.addBundle(textMateBundle.path, "zmodel")
-        val textMateService = TextMateService.getInstance();
-        textMateService.reloadEnabledBundles()
+        Utils.Companion.addTextMateBundle()
 
         // start language server
         val interpreter = NodeJsInterpreterManager.getInstance(project).interpreter

packages/ide/jetbrains/src/main/kotlin/dev/zenstack/Utils.kt

@@ -0,0 +1,18 @@
+package dev.zenstack.plugin
+
+import com.intellij.ide.plugins.DynamicPluginListener
+import com.intellij.ide.plugins.IdeaPluginDescriptor
+import dev.zenstack.Utils
+import org.jetbrains.plugins.textmate.TextMateService
+
+class PluginStateListener: DynamicPluginListener {
+    override fun beforePluginLoaded(pluginDescriptor: IdeaPluginDescriptor) {
+        // install TextMate bundle
+        Utils.Companion.addTextMateBundle()
+    }
+
+    override fun beforePluginUnload(pluginDescriptor: IdeaPluginDescriptor, isUpdate: Boolean) {
+        // uninstall TextMate bundle
+        Utils.disableTextMateBundle()
+    }
+}

packages/ide/jetbrains/src/main/kotlin/dev/zenstack/lsp/ZenStackLspServerDescriptor.kt

@@ -20,8 +20,10 @@
 
         <ul>
             <li>Syntax highlighting</li>
+            <li>Error highlighting</li>
             <li>Go to definition</li>
             <li>Code completion</li>
+            <li>Formatting</li>
         </ul>
     ]]></description>
 
@@ -54,4 +56,12 @@
                 implementationClass="org.jetbrains.plugins.textmate.language.syntax.highlighting.TextMateSyntaxHighlighterFactory"/>
 
     </extensions>
+
+    <applicationListeners>
+        <listener
+                class="dev.zenstack.plugin.PluginStateListener"
+                topic="com.intellij.ide.plugins.DynamicPluginListener"/>
+    </applicationListeners>
+
+    <idea-version since-build="233.2" />
 </idea-plugin>