drivers: rtc: ds3231: fix uninitialized variable error

kartben · kartben · commit 11a9096c7c9f · 2025-09-03T11:04:07.000+02:00
Until recently this driver wasn't built in CI. Now that it is, clang
is complaining about `err` possibly being uninitialized in case
`bitmask` is 255. Fix it by actually removing code that was
unnecessarily trying to access the uninitialized variable.

Signed-off-by: Benjamin Cabé &lt;benjamin@zephyrproject.org&gt;
diff --git a/drivers/rtc/rtc_ds3231.c b/drivers/rtc/rtc_ds3231.c
@@ -74,9 +74,6 @@ static int rtc_ds3231_modify_register(const struct device *dev, uint8_t reg, uin
 		og_buf |= *buf;
 		*buf = og_buf;
 	}
-	if (err != 0) {
-		return err;
-	}
 	err = mfd_ds3231_i2c_set_registers(config->mfd, reg, buf, 1);
 	return err;
 }

Original file line number	Diff line number	Diff line change
`@@ -74,9 +74,6 @@ static int rtc_ds3231_modify_register(const struct device *dev, uint8_t reg, uin`
`74`	`74`	`og_buf \|= *buf;`
`75`	`75`	`*buf = og_buf;`
`76`	`76`	`}`
`77`		`- if (err != 0) {`
`78`		`- return err;`
`79`		`- }`
`80`	`77`	`err = mfd_ds3231_i2c_set_registers(config->mfd, reg, buf, 1);`
`81`	`78`	`return err;`
`82`	`79`	`}`