scripts: check_init_priorities: Fix file leak

The elf file needs to be closed after done being used, otherwise sys
module will generate resource leak warnings.

Signed-off-by: Declan Snyder <[email protected]>

Author: decsny

scripts/build/check_init_priorities.py

@@ -98,9 +98,9 @@ class variables in the {"level name": ["call", ...]} format.
     Attributes:
         file_path: path of the file to be loaded.
     """
-    def __init__(self, file_path):
+    def __init__(self, file_path, elf_file):
         self.file_path = file_path
-        self._elf = ELFFile(open(file_path, "rb"))
+        self._elf = ELFFile(elf_file)
         self._load_objects()
         self._load_level_addr()
         self._process_initlevels()
@@ -226,7 +226,7 @@ class Validator():
         edt_pickle: name of the EDT pickle file
         log: a logging.Logger object
     """
-    def __init__(self, elf_file_path, edt_pickle, log):
+    def __init__(self, elf_file_path, edt_pickle, log, elf_file):
         self.log = log
 
         edt_pickle_path = pathlib.Path(
@@ -237,7 +237,7 @@ def __init__(self, elf_file_path, edt_pickle, log):
 
         self._ord2node = edt.dep_ord2node
 
-        self._obj = ZephyrInitLevels(elf_file_path)
+        self._obj = ZephyrInitLevels(elf_file_path, elf_file)
 
         self.errors = 0
 
@@ -344,17 +344,18 @@ def main(argv=None):
 
     log.info(f"check_init_priorities: {args.elf_file}")
 
-    validator = Validator(args.elf_file, args.edt_pickle, log)
-    if args.initlevels:
-        validator.print_initlevels()
-    else:
-        validator.check_edt()
+    with open(args.elf_file, "rb") as elf_file:
+        validator = Validator(args.elf_file, args.edt_pickle, log, elf_file)
+        if args.initlevels:
+            validator.print_initlevels()
+        else:
+            validator.check_edt()
 
-    if args.always_succeed:
-        return 0
+        if args.always_succeed:
+            return 0
 
-    if validator.errors:
-        return 1
+        if validator.errors:
+            return 1
 
     return 0