2 problems with global constants.

[stephan57160]

Problem: global constants name and descriptions are buggy, compared to per-class constants.

• constant names with spaces are handled correctly when defined per class (in foo.api), but not when defined globaly (project.xml).
• when I looked for a fix, I also identified something I fixed last year, for class constant descriptions.

Solution: Fix generated global constant names and their description.

• Use $(CONSTANT.NAME:c) instead of $(CONSTANT.NAME) in zproject_class.gls.
• Use a similar approach to Fixed multi line constant description in C headers. #1283 to fix the constant description.

Example:
Extract of project.xml:

  <constant name = "global constant stuff" value = "123" type = "string" >
    this is a
    multi-line comment
    for global constant
  </constant>

Generated file:

#define GLOBAL CONSTANT STUFF  "123"           //
    this is a
    multi-line comment
    for global constant

As a consequence, C compilation fails:

make[1]: Entering directory `/home/cbox_dev/git/zproject-issues-testing'
  CC       src/src_libfbp_la-foo.lo
In file included from src/../include/libfoobar.h:18:0,
                 from src/fbp_classes.h:35,
                 from src/foo.c:21:
src/../include/fbp_library.h:95:5: error: unknown type name 'this'
     this is a
     ^
src/../include/fbp_library.h:95:13: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'a'
     this is a
             ^

I know it's not the rule, but as both fixes are really close, would you accept a single PR for both ?

[stephan57160]

For referene :

prompt> grep CONSTANT\.NAME zproject/zproject_class.gsl 
#define $(CONSTANT.NAME)\
#define $(CONSTANT.NAME)\
#define $(CONSTANT.NAME)\
#define $(CONSTANT.NAME)\t$(constant.value) //  $(constant.?'')
prompt>

[stephan57160]

Additionnally, I would add $(PROJECT.PREFIX:c)_ as a prefix for a global constant name, like it is for project version constants.
Without project.prefix:

//  FOOBARPROJECT version macros for compile-time API detection
#define FOOBARPROJECT_VERSION_MAJOR 4
#define FOOBARPROJECT_VERSION_MINOR 5
#define FOOBARPROJECT_VERSION_PATCH 6

with project.prefix = "FBP" :

#define FBP_VERSION_MAJOR 4
#define FBP_VERSION_MINOR 5
#define FBP_VERSION_PATCH 6

But ... this would break existing projects ...

[stephan57160]

Closing, as PR is accepted.