You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Was 'playing' with builds/android/ci_build.sh and bindings/jni/ci_build.sh for a while, with the idea to use them by our own applications to generate ZYRE jar file for our Android application(s).
Found them interesting, but buggy, and probably incomplete. Below, a partial list of my findings:
{CZMQ,ZYRE}/builds/android/ci_build.sh: silently fail (no use of set -e).
As per my investigations, may require a few other modifications, because failing when set.
{CZMQ,ZYRE}/builds/android/build.sh: silently fail (no use of set -e).
As per my investigations, may require a few other modifications, because failing when set.
CZMQ/builds/android/ci_build.sh: clone LIBMICROHTTPD repository, instead of using the TARBALL.
This already raises an error during build, but not yet seen because of 1.
zproject_known_projects.xml: Show invalid repo for LIBMICROHTTPD.
The given URL is wrong, so, it's probably an old version.
Don't know how to fix this one, as there is no way (yet) to indicate a tarball download.
Any idea is welcome.
Enhancement: There is no way to rebuild ZYRE, using existing folders, to facilitate troubleshooting.
zproject_*.gsl contain many places where 'android-ndk-xxx' is defined: Could be usefull to have a unique variable.
Enhancement: NDK download is performed in a few places, but could be in the existing android helper file.
Enhancement: HOST_PLATFORM is currently exported, but this may lead to build problems, when building dependencies.
Actually, there is no reason to export it, and it should be initialized in the Android helper too.
Simplification: After a previous PR, GSL code shows things like if a then B else B (no effect on generated code).
./configure used with --with-docs=no, when usually, the syntax is more --without-docs.
android helpers do not validate dependencies, despite its documentation.
This problem was initially detected in libzmq, by the way.
Dump ./configure parameters.
Already in use to troubleshoot some existing problem.
Additionnally:
found also some minor typos, here or there.
ZYRE Android CI build could be updated to be closer to the Zproject generated one.
Any input on the CI build system is welcome.
I already to work on them, and started a android-build-enhancements branch in my fork.
Same branch exists in my forks LIBZMQ, CZMQ & ZYRE.
I'll do, as usual : 1 commit for a unique solution to a unique problem, to minimize the modifications.
The text was updated successfully, but these errors were encountered:
Was 'playing' with
builds/android/ci_build.sh
andbindings/jni/ci_build.sh
for a while, with the idea to use them by our own applications to generate ZYRE jar file for our Android application(s).Found them interesting, but buggy, and probably incomplete. Below, a partial list of my findings:
{CZMQ,ZYRE}/builds/android/ci_build.sh: silently fail (no use of
set -e
).As per my investigations, may require a few other modifications, because failing when set.
{CZMQ,ZYRE}/builds/android/build.sh: silently fail (no use of
set -e
).As per my investigations, may require a few other modifications, because failing when set.
CZMQ/builds/android/ci_build.sh: clone LIBMICROHTTPD repository, instead of using the TARBALL.
This already raises an error during build, but not yet seen because of 1.
zproject_known_projects.xml: Show invalid repo for LIBMICROHTTPD.
The given URL is wrong, so, it's probably an old version.
Don't know how to fix this one, as there is no way (yet) to indicate a tarball download.
Any idea is welcome.
Enhancement: There is no way to rebuild ZYRE, using existing folders, to facilitate troubleshooting.
zproject_*.gsl contain many places where 'android-ndk-xxx' is defined: Could be usefull to have a unique variable.
Enhancement: NDK download is performed in a few places, but could be in the existing android helper file.
Enhancement: HOST_PLATFORM is currently exported, but this may lead to build problems, when building dependencies.
Actually, there is no reason to export it, and it should be initialized in the Android helper too.
Simplification: After a previous PR, GSL code shows things like
if a then B else B
(no effect on generated code)../configure used with
--with-docs=no
, when usually, the syntax is more--without-docs
.android helpers do not validate dependencies, despite its documentation.
This problem was initially detected in libzmq, by the way.
Dump ./configure parameters.
Already in use to troubleshoot some existing problem.
Additionnally:
Any input on the CI build system is welcome.
I already to work on them, and started a
android-build-enhancements
branch in my fork.Same branch exists in my forks LIBZMQ, CZMQ & ZYRE.
I'll do, as usual : 1 commit for a unique solution to a unique problem, to minimize the modifications.
The text was updated successfully, but these errors were encountered: