Skip to content

Commit 14baf7e

Browse files
auvipytomchristie
authored andcommitted
converted serializer bulk update test asserts to pytest (encode#4805)
1 parent f67f2ab commit 14baf7e

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

tests/test_serializer_bulk_update.py

+12-12
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ def test_bulk_create_success(self):
4444
]
4545

4646
serializer = self.BookSerializer(data=data, many=True)
47-
self.assertEqual(serializer.is_valid(), True)
48-
self.assertEqual(serializer.validated_data, data)
49-
self.assertEqual(serializer.errors, [])
47+
assert serializer.is_valid() is True
48+
assert serializer.validated_data == data
49+
assert serializer.errors == []
5050

5151
def test_bulk_create_errors(self):
5252
"""
@@ -75,17 +75,17 @@ def test_bulk_create_errors(self):
7575
]
7676

7777
serializer = self.BookSerializer(data=data, many=True)
78-
self.assertEqual(serializer.is_valid(), False)
79-
self.assertEqual(serializer.errors, expected_errors)
80-
self.assertEqual(serializer.validated_data, [])
78+
assert serializer.is_valid() is False
79+
assert serializer.errors == expected_errors
80+
assert serializer.validated_data == []
8181

8282
def test_invalid_list_datatype(self):
8383
"""
8484
Data containing list of incorrect data type should return errors.
8585
"""
8686
data = ['foo', 'bar', 'baz']
8787
serializer = self.BookSerializer(data=data, many=True)
88-
self.assertEqual(serializer.is_valid(), False)
88+
assert serializer.is_valid() is False
8989

9090
text_type_string = six.text_type.__name__
9191
message = 'Invalid data. Expected a dictionary, but got %s.' % text_type_string
@@ -95,19 +95,19 @@ def test_invalid_list_datatype(self):
9595
{'non_field_errors': [message]}
9696
]
9797

98-
self.assertEqual(serializer.errors, expected_errors)
98+
assert serializer.errors == expected_errors
9999

100100
def test_invalid_single_datatype(self):
101101
"""
102102
Data containing a single incorrect data type should return errors.
103103
"""
104104
data = 123
105105
serializer = self.BookSerializer(data=data, many=True)
106-
self.assertEqual(serializer.is_valid(), False)
106+
assert serializer.is_valid() is False
107107

108108
expected_errors = {'non_field_errors': ['Expected a list of items but got type "int".']}
109109

110-
self.assertEqual(serializer.errors, expected_errors)
110+
assert serializer.errors == expected_errors
111111

112112
def test_invalid_single_object(self):
113113
"""
@@ -120,8 +120,8 @@ def test_invalid_single_object(self):
120120
'author': 'Tom Wolfe'
121121
}
122122
serializer = self.BookSerializer(data=data, many=True)
123-
self.assertEqual(serializer.is_valid(), False)
123+
assert serializer.is_valid() is False
124124

125125
expected_errors = {'non_field_errors': ['Expected a list of items but got type "dict".']}
126126

127-
self.assertEqual(serializer.errors, expected_errors)
127+
assert serializer.errors == expected_errors

0 commit comments

Comments
 (0)