Implement instance table API #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similarly to having an option to bypass global instance function pointers in favor of an instance function table, we now provide an API to load instance pointers into a separate structure. This makes it possible to create multiple instances and use them concurrently; this isn't needed as often as multi-device API but can still be valuable for some applications.
The only differences between device/instance/loader snippets is where to include each one based on command type
Owner
Author
|
This runs into a problem with |
…ProcAddr In the future we might expose something like volkLoadInstanceDeviceTable (which would take both instance and device handles), but with the current interface the only option is to load an extra pointer, which technically is instance-specific.
Closed
This mirrors similar support in VolkDeviceTable and ensures that volk ABI is stable between changes in configuration macros.
This makes sure that padding fields are initialized to zero; if volk is compiled without some defines, the associated function pointers in the returned struct will be NULL instead of uninitialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to having an option to bypass global device function
pointers in favor of a device function table, we now provide an API
to load instance pointers into a separate structure.
This makes it possible to create multiple instances and use them
concurrently; this isn't needed as often as multi-device API but can
still be valuable for some applications.
Fixes #137
(needs further testing)