Skip to content

Commit 119b1d2

Browse files
committed
[FEATURE] Add comsumeWhitespaceWithComments and redirect comsumeWhitespace (MyIntervals#670)
Having comsumeWhitespace also consume comments and returning them was unexpected. Signed-off-by: Daniel Ziegenberg <[email protected]>
1 parent d2fb94a commit 119b1d2

File tree

2 files changed

+21
-2
lines changed

2 files changed

+21
-2
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,12 @@ This project adheres to [Semantic Versioning](https://semver.org/).
77

88
### Added
99

10+
- Add `ParserState::comsumeWhitespaceWithComments()` method (#670)
11+
1012
### Changed
1113

14+
- Redirect `ParserState::comsumeWhitespace()` to `ParserState::comsumeWhitespaceWithComments()` (#670)
15+
1216
### Deprecated
1317

1418
### Removed

src/Parsing/ParserState.php

+17-2
Original file line numberDiff line numberDiff line change
@@ -226,12 +226,27 @@ public function parseCharacter($bIsForIdentifier)
226226
}
227227

228228
/**
229-
* @return array<int, Comment>|void
229+
* Consumes whitespace and comments and returns a list of comments.
230+
*
231+
* @return list<Comment> List of comments.
232+
*
233+
* @throws UnexpectedEOFException
234+
* @throws UnexpectedTokenException
235+
*/
236+
public function comsumeWhitespace()
237+
{
238+
return $this->comsumeWhitespaceWithComments();
239+
}
240+
241+
/**
242+
* Consumes whitespace and comments and returns a list of comments.
243+
*
244+
* @return list<Comment> List of comments.
230245
*
231246
* @throws UnexpectedEOFException
232247
* @throws UnexpectedTokenException
233248
*/
234-
public function consumeWhiteSpace()
249+
public function comsumeWhitespaceWithComments()
235250
{
236251
$aComments = [];
237252
do {

0 commit comments

Comments
 (0)