no switch case completion on function inside container

[Techatrix]

Zig Version

0.12.0-dev.978+78855bd21

Zig Language Server Version

1a282b3

Steps to Reproduce

const E = enum {
    foo,
    bar,
    baz,
    fn foo(e: E) void {
        switch (e) {.<ask for completions here>}
    }
};

Expected Behavior

List all fields of E i.e. foo, bar and baz.

Actual Behavior

no completions.

Hovering of e inside the switch expression yields no result which is the underlying problem.
If you move foo outside of the enum, then it works.

This looks like one of those situations where the parser goes crazy.

[llogick]

I keep repeating it, but before anyone dives into the completions logic — parser limitation.
The workarounds (I know, not ideal):

• structs => S{1.};
• switch => switch (e) {.}};

[Techatrix]

Instead of expecting users to know about a workaround, this shouldn't be necessary. This issue with the parser should be investigated and resolved upstream.

[llogick]

I don't mean to nag, simply posted it as a heads-up to anyone that might look into it, and the workarounds as a proof/way to verify that the issue stems from syntax errors.

The reason I refer to it as limitation is that it's only an issue for third parties

• Roughly track the last token in each AST node ziglang/zig#14391 (comment)
  although you might be able to influence some changes
• Regression: Stack overflow when initializing large struct with initializer syntax. ziglang/zig#17289 (comment)

I've experimented with passing true(recoverable) here
https://github.com/ziglang/zig/blob/eb5276c94eaab238551fdae9a2e77b0133e31cfb/lib/std/zig/Parse.zig#L876
and from what I can tell it solves most of these, the exception being completions within a struct/switch if the type node is defined outside and after the current node.

I've also explored making additional changes, but not certain the benefits warrant supporting custom node tags.

[Techatrix]

This appears to be fixed by #1536.