Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate use of Reader / Writer #19

Open
jdegoes opened this issue Sep 22, 2020 · 3 comments
Open

Eliminate use of Reader / Writer #19

jdegoes opened this issue Sep 22, 2020 · 3 comments

Comments

@jdegoes
Copy link
Member

jdegoes commented Sep 22, 2020

Most likely we can improve performance by eliminating read / writer and going directly with inputstream / outputstream or classes baked on these.

@fakirAyoub
Copy link

Hi, I'll take this one!

@jdegoes
Copy link
Member Author

jdegoes commented Sep 25, 2020

@fakirAyoub Awesome. Let me know if you need a hand!

If you look into the implementation of java's Reader / Writer, you can see extraneous copying of bytes, which we can probably eliminate or reduce in our own versions. Of course, the benchmarks will tell the truth here, we should rely on them to see if we can actually improve performance or not.

@fsvehla
Copy link
Contributor

fsvehla commented Nov 9, 2020

@fakirAyoub How did this go, were you able to make some progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants