Skip to content

Commit 81e5c56

Browse files
authored
Merge pull request #447 from psy-q/fix_rspec_syntax_deprecations
Get rid of deprecated .should syntax in readme
2 parents 5571121 + e850da7 commit 81e5c56

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

Diff for: README.md

+18-18
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ resource "Orders" do
3838
example "Listing orders" do
3939
do_request
4040

41-
status.should == 200
41+
expect(status).to eq 200
4242
end
4343
end
4444
end
@@ -517,18 +517,18 @@ resource "Account" do
517517
# default :document is :all
518518
example "Get a list of all accounts" do
519519
do_request
520-
status.should == 200
520+
expect(status).to eq 200
521521
end
522522

523523
# Don't actually document this example, purely for testing purposes
524524
example "Get a list on page 2", :document => false do
525525
do_request(:page => 2)
526-
status.should == 404
526+
expect(status).to eq 404
527527
end
528528

529529
# With example_request, you can't change the :document
530530
example_request "Get a list on page 3", :page => 3 do
531-
status.should == 404
531+
expect(status).to eq 404
532532
end
533533
end
534534

@@ -537,12 +537,12 @@ resource "Account" do
537537

538538
example "Creating an account", :document => :private do
539539
do_request(:email => "[email protected]")
540-
status.should == 201
540+
expect(status).to eq 201
541541
end
542542

543543
example "Creating an account - errors", :document => [:private, :developers] do
544544
do_request
545-
status.should == 422
545+
expect(status).to eq 422
546546
end
547547
end
548548
end
@@ -611,7 +611,7 @@ resource "Orders" do
611611
let(:id) { order.id }
612612

613613
example "Get an order" do
614-
path.should == "/orders/1" # `:id` is replaced with the value of `id`
614+
expect(path).to eq "/orders/1" # `:id` is replaced with the value of `id`
615615
end
616616
end
617617

@@ -701,7 +701,7 @@ resource "Orders" do
701701

702702
get "/orders" do
703703
example_request "Headers" do
704-
headers.should == { "Accept" => "application/json", "X-Custom" => "dynamic" }
704+
expect(headers).to eq { "Accept" => "application/json", "X-Custom" => "dynamic" }
705705
end
706706
end
707707
end
@@ -740,7 +740,7 @@ resource "Orders" do
740740
# OR let(:order_item_item_id) { 1 }
741741

742742
example "Creating an order" do
743-
params.should eq({
743+
expect(params).to eq({
744744
:order => {
745745
:name => "My Order",
746746
:item => {
@@ -829,7 +829,7 @@ resource "Order" do
829829

830830
do_request
831831

832-
status.should == 200
832+
expect(status).to eq 200
833833
end
834834
end
835835
end
@@ -849,7 +849,7 @@ resource "Order" do
849849
example "Listing orders" do
850850
do_request
851851

852-
status.should == 200
852+
expect(status).to eq 200
853853
end
854854
end
855855
end
@@ -870,7 +870,7 @@ resource "Order" do
870870

871871
do_request
872872

873-
status.should == 200
873+
expect(status).to eq 200
874874
end
875875
end
876876
end
@@ -892,7 +892,7 @@ resource "Orders" do
892892

893893
get "/orders" do
894894
example_request "Headers" do
895-
headers.should == { "Accept" => "application/json" }
895+
expect(headers).to eq { "Accept" => "application/json" }
896896
end
897897
end
898898
end
@@ -912,7 +912,7 @@ resource "Order" do
912912
example "Listing orders" do
913913
do_request
914914

915-
response_body.should == [{ :name => "Order 1" }].to_json
915+
expect(response_body).to eq [{ :name => "Order 1" }].to_json
916916
end
917917
end
918918
end
@@ -928,7 +928,7 @@ resource "Order" do
928928
example "Listing orders" do
929929
do_request
930930

931-
response_headers["Content-Type"].should == "application/json"
931+
expect(response_headers["Content-Type"]).to eq "application/json"
932932
end
933933
end
934934
end
@@ -944,8 +944,8 @@ resource "Order" do
944944
example "Listing orders" do
945945
do_request
946946

947-
status.should == 200
948-
response_status.should == 200
947+
expect(status).to eq 200
948+
expect(response_status).to eq 200
949949
end
950950
end
951951
end
@@ -963,7 +963,7 @@ resource "Orders" do
963963

964964
get "/orders" do
965965
example "List orders" do
966-
query_string.should == "name=My+Orders"
966+
expect(query_string).to eq "name=My+Orders"
967967
end
968968
end
969969
end

0 commit comments

Comments
 (0)