Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery #70

Open
krutburken opened this issue Aug 26, 2022 · 4 comments
Open

Gallery #70

krutburken opened this issue Aug 26, 2022 · 4 comments
Milestone

Comments

@krutburken
Copy link

krutburken commented Aug 26, 2022

Hello! I'm trying to use the hugo-shortcode-gallery together with this theme, but I seem to be running into the same issue as mfg92/hugo-shortcode-gallery#19 which seems to point to a theme incompatibility.

The error I'm getting is gallery.justifiedgallery is not a function

Sadly I'm quite new to the whole hugo-thing so I'm not exactly sure what the fix would be in this case. Any pointers?

@stale stale bot added the wontfix This will not be worked on - potentilly falsely applied by stalebot, use invalid label instead label Oct 28, 2022
@stale stale bot closed this as completed Nov 27, 2022
@zjedi zjedi reopened this Mar 11, 2023
@stale stale bot removed the wontfix This will not be worked on - potentilly falsely applied by stalebot, use invalid label instead label Mar 11, 2023
@zjedi zjedi changed the title Compatibility with hugo-shortcode-gallery Gallery Mar 12, 2023
@zjedi zjedi added this to the v2.0 milestone Apr 2, 2023
@zjedi
Copy link
Owner

zjedi commented Dec 24, 2023

I think we should go with https://photoswipe.com = https://github.com/dimsemenov/photoswipe
since they have enough features and compatible license

Repository owner deleted a comment from stale bot Dec 24, 2023
@jonas37
Copy link

jonas37 commented May 9, 2024

What about https://hugocodex.org/add-ons/slider-carousel/

I used the lightbox https://hugocodex.org/add-ons/lightbox/
When you add hyperlinks to the source file of an image this works out of the box
But now i run into the issue that each image is displayed with full page/content width. and I cant make it display smaller images side by side.

@zjedi
Copy link
Owner

zjedi commented May 9, 2024

@jonas37 Thanks for suggestion, looks ok, but it is a little different use case. A separate feature I would say. We can have both Gallery option and carousel option.

I can see they also have https://hugocodex.org/add-ons/image-gallery/ , but it seems pretty basic (not even left/right keys working)

@keesfluitman
Copy link

keesfluitman commented Dec 12, 2024

@jonas37 Thanks for suggestion, looks ok, but it is a little different use case. A separate feature I would say. We can have both Gallery option and carousel option.

I can see they also have hugocodex.org/add-ons/image-gallery , but it seems pretty basic (not even left/right keys working)

any idea how you would integrate photoswipe then? image-gallery is really basic indeed. Doesnt this repo also work with sub modules? Im using the https://github.com/gethugothemes/hugo-modules/tree/master/gallery-slider in a different project. Ill test how it works as shortcode.

Ive now used the gallery, plus lightbox, added a listener for keyboard input as well. That works, but seems like it could be easier?
@jonas37 So if u add the image-gallery, it will use a simple grid. The lightbox then makes sure it becomes a slideshow when clicking an image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants