Skip to content

Commit 7f49e27

Browse files
authored
[myt/wacca] remove version compat code (#1292)
1 parent fbab514 commit 7f49e27

4 files changed

Lines changed: 1 addition & 28 deletions

File tree

server/src/lib/score-import/import-types/api/myt-wacca/class-handler.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,16 @@ export default async function CreateMytWACCAClassHandler(
1818
const data = dataRes;
1919

2020
return (_gptString, _userID, _ratings, _logger) => {
21-
// In Apr/May 2025, the keys for version data are changing from
22-
// 0-indexed (starting at WACCA) to custom enum values.
23-
// TODO: Once MYT transitions over to the new enum, remove the _OLD
24-
// values from the enum proto definition, and remove the compatibility
25-
// code below.
26-
// Currently (Apr. 2025) Reverse and Plus are supported on Myt.
21+
// Currently (May 2025) Reverse and Plus are supported on Myt.
2722
// We look for both Reverse and PLUS version data, PLUS being prioritized if exists.
2823
// If / when custom dans are added, this will need to change.
2924
const versionDataMap = data.getVersionDataMap();
3025
let versionData: DataResponse.VersionData | undefined;
3126

3227
if (versionDataMap.has(WaccaVersion.WACCA_VERSION_PLUS)) {
3328
versionData = versionDataMap.get(WaccaVersion.WACCA_VERSION_PLUS);
34-
} else if (versionDataMap.has(WaccaVersion.WACCA_VERSION_PLUS_OLD)) {
35-
versionData = versionDataMap.get(WaccaVersion.WACCA_VERSION_PLUS_OLD);
3629
} else if (versionDataMap.has(WaccaVersion.WACCA_VERSION_REVERSE)) {
3730
versionData = versionDataMap.get(WaccaVersion.WACCA_VERSION_REVERSE);
38-
} else if (versionDataMap.has(WaccaVersion.WACCA_VERSION_REVERSE_OLD)) {
39-
versionData = versionDataMap.get(WaccaVersion.WACCA_VERSION_REVERSE_OLD);
4031
}
4132

4233
// rank:

server/src/proto/generated/wacca/common_pb.d.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,6 @@ export namespace WaccaJudge {
7373

7474
export interface WaccaVersionMap {
7575
WACCA_VERSION_UNSPECIFIED: 0;
76-
WACCA_VERSION_S_OLD: 1;
77-
WACCA_VERSION_LILY_OLD: 2;
78-
WACCA_VERSION_LILY_R_OLD: 3;
79-
WACCA_VERSION_REVERSE_OLD: 4;
80-
WACCA_VERSION_PLUS_OLD: 5;
8176
WACCA_VERSION_WACCA: 100;
8277
WACCA_VERSION_S: 150;
8378
WACCA_VERSION_LILY: 200;

server/src/proto/generated/wacca/common_pb.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -544,11 +544,6 @@ proto.mythos.wacca.v0.WaccaJudge.prototype.setMiss = function(value) {
544544
*/
545545
proto.mythos.wacca.v0.WaccaVersion = {
546546
WACCA_VERSION_UNSPECIFIED: 0,
547-
WACCA_VERSION_S_OLD: 1,
548-
WACCA_VERSION_LILY_OLD: 2,
549-
WACCA_VERSION_LILY_R_OLD: 3,
550-
WACCA_VERSION_REVERSE_OLD: 4,
551-
WACCA_VERSION_PLUS_OLD: 5,
552547
WACCA_VERSION_WACCA: 100,
553548
WACCA_VERSION_S: 150,
554549
WACCA_VERSION_LILY: 200,

server/src/proto/myt/wacca/common.proto

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,6 @@ package mythos.wacca.v0;
55

66
enum WaccaVersion {
77
WACCA_VERSION_UNSPECIFIED = 0;
8-
9-
// TODO: once MYT transitions over to the new enum, remove the _OLD values
10-
WACCA_VERSION_S_OLD = 1;
11-
WACCA_VERSION_LILY_OLD = 2;
12-
WACCA_VERSION_LILY_R_OLD = 3;
13-
WACCA_VERSION_REVERSE_OLD = 4;
14-
WACCA_VERSION_PLUS_OLD = 5;
15-
168
WACCA_VERSION_WACCA = 100;
179
WACCA_VERSION_S = 150;
1810
WACCA_VERSION_LILY = 200;

0 commit comments

Comments
 (0)