basic commit #173
Open
basic commit #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is it right? Signed-off-by: v1gnesh <[email protected]>
v1gnesh
requested review from
IgorTodorovskiIBM and
MikeFultonDev
as code owners
Collaborator
Author
|
augment review |
🤖 Augment PR SummarySummary: Updates the vendored patch 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| + * cannot be used (unless reinitialized with fetch_negotiator_init()). | ||
| */ | ||
| struct fetch_negotiator { | ||
| struct fetch_nogotiator { |
There was a problem hiding this comment.
struct fetch_nogotiator looks like a misspelling and is inconsistent with the rest of this patch, which still refers to struct fetch_negotiator (e.g., function pointer types below). As-is, the patch will likely fail to apply cleanly or will fail to compile after application due to the type-name mismatch.
🤖 Was this useful? React with 👍 or 👎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is it right? What will Augment say?