cgo with zopen header files

[fswarbrick]

If I do a "go build" for a project that uses cgo, if the zopen header for time.h (${HOME}/zopen/usr/local/include/time.h) is included, it causes some "redefinition issues". Here is what I am seeing:

$ go build ~/repos/elvish/...
# runtime/cgo
In file included from gcc_context.c:7:
In file included from ../.local/usr/go/src/runtime/cgo/libcgo.h:154:
../zopen/usr/local/include/time.h:46:3: error: expected identifier
  CLOCK_REALTIME,
  ^
/usr/include/time.h:106:33: note: expanded from macro 'CLOCK_REALTIME'
      #define CLOCK_REALTIME    0
                                ^
In file included from gcc_context.c:7:
In file included from ../.local/usr/go/src/runtime/cgo/libcgo.h:154:
../zopen/usr/local/include/time.h:47:3: error: expected identifier
  CLOCK_MONOTONIC,
  ^
/usr/include/time.h:107:33: note: expanded from macro 'CLOCK_MONOTONIC'
      #define CLOCK_MONOTONIC   1
                                ^
In file included from gcc_context.c:7:
In file included from ../.local/usr/go/src/runtime/cgo/libcgo.h:154:
../zopen/usr/local/include/time.h:50:3: error: typedef redefinition with different types ('enum clockid_t' vs 'unsigned int')
} clockid_t;
  ^
/usr/include/sys/types.h:277:35: note: previous definition is here
            typedef unsigned  int clockid_t;
                                  ^
3 errors generated.
2024/05/09 10:23:55 Running [/u/dvfjs/.local/usr/lpp/IBM/oelcpp/v2r0/bin/clang -U_ENHANCED_ASCII_EXT -D_AE_BIMODAL=1 -D_ALL_SOURCE -D_ENHANCED_ASCII_EXT=0xFFFFFFFF -D_Export=extern -D_LARGE_TIME_API -D_OPEN_MSGQ_EXT -D_OPEN_SYS_FILE_EXT=1 -D_OPEN_SYS_SOCK_IPV6  -DPATH_MAX=1023 -D__static_assert=static_assert -D_UNIX03_SOURCE  -D_UNIX03_THREADS -D_UNIX03_WITHDRAWN -D_XOPEN_SOURCE=600 -D_XOPEN_SOURCE_EXTENDED -D_XPLATFORM_SOURCE=1 -m64 -fzos-le-char-mode=ascii -march=z13 -fasm -mno-rent -isystem/usr/include -Wno-unused-command-line-argument -I ../.local/usr/go/src/runtime/cgo -m64 -Qunused-arguments -I $WORK/b082/ -O2 -g -Wall -Werror -fno-stack-protector -Wno-error=unused-command-line-argument -c -mcsect=gcc_context.c67240276 -MD gcc_context.c -o $WORK/b082/_x003.o] has failed:exit status 1

[/u/dvfjs/.local/usr/go/bin/clang-wrapper -I ../.local/usr/go/src/runtime/cgo -fPIC -m64 -pthread -Qunused-arguments -fmessage-length=0 -I $WORK/b082/ -O2 -g -Wall -Werror -fno-stack-protector -Wno-error=unused-command-line-argument -o $WORK/b082/_x003.o -c gcc_context.c]

If I don't include ${HOME}/zopen/usr/local/include then it compiles just fine.

This is on z/OS 2.5 with IBM C/C++ for Open Enterprise Languages on z/OS (clang-14) and IBM Open Enterprise SDK for Go (go1.22.2 zos/s390x). And obviously zOpen tools.

Thoughts?

[IgorTodorovskiIBM]

the zopen time.h is coming from zoslib which is intended to be used with target=zosv2r4. However, we do aim to fix soon so that it can be built on V2R5.

[IgorTodorovskiIBM]

The issue is mainly with zoslib's use of an enum vs macro in /usr/include/time.h

[fswarbrick]

I'm not sure what to do with this information. Are you saying zoslib is not compatible with z/OS 2.5?

[IgorTodorovskiIBM]

Yes, but good news is there's a fix coming to zoslib to address the time.h issue - ibmruntimes/zoslib#59 (review)

[fswarbrick]

Ah, I understand the issue now. Some new things were defined for z/OS 2.5 (not existing before then), and the zoslib time.h definition conflicts with the supplied time.h. Thanks!