msglist [nfc]: Maintain middleItem as a field

This new logic maintains `middleItem` according to its documented
relationship with `middleMessage`.  Because of the current
definition of `middleMessage`, that produces the same result as
the previous definition of `middleItem`.

The key reasoning for why this logic works is: this touches all the
code that modifies `items`, to ensure that code keeps `middleItem`
up to date.  And all the code which modifies `messages` (which is
the only way to modify `middleMessage`) already calls
`_reprocessAll` to compute `items` from scratch, except one site
in `_addMessage`.  Studying `_addMessage`, it also maintains
`middleItem` correctly, though for that conclusion one needs the
specifics of the definition of `middleMessage`.

This change involves no new test code: all this logic is in
scenarios well exercised by existing tests, and the invariant-checks
introduced in the previous commit then effectively test this logic.
To be sure of that, I also confirmed that commenting out any one of
these updates to `middleItem` causes some tests to fail.

Author: gnprice

lib/model/message_list.dart

@@ -163,25 +163,7 @@ mixin _MessageSequence {
   /// Either the bottom slices of both [items] and [messages] are empty,
   /// or the first item in the bottom slice of [items] is a [MessageListMessageItem]
   /// for the first message in the bottom slice of [messages].
-  int get middleItem {
-    switch (items.lastOrNull) {
-      case null:
-        return 0;
-
-      case MessageListHistoryStartItem():
-        assert(items.length == 1);
-        return items.length;
-
-      case MessageListMessageItem():
-        return items.length - 1;
-
-      case MessageListLoadingItem(direction: MessageListDirection.older):
-      case MessageListRecipientHeaderItem():
-      case MessageListDateSeparatorItem():
-        assert(false, "unexpected type of last item");
-        return items.length - 1;
-    }
-  }
+  int middleItem = 0;
 
   int _findMessageWithId(int messageId) {
     return binarySearchByKey(messages, messageId,
@@ -313,6 +295,7 @@ mixin _MessageSequence {
     _fetchOlderCooldownBackoffMachine = null;
     contents.clear();
     items.clear();
+    middleItem = 0;
   }
 
   /// Redo all computations from scratch, based on [messages].
@@ -352,6 +335,7 @@ mixin _MessageSequence {
         canShareSender = (prevMessageItem.message.senderId == message.senderId);
       }
     }
+    if (index == middleMessage) middleItem = items.length;
     items.add(MessageListMessageItem(message, content,
       showSender: !canShareSender, isLastInBlock: true));
   }
@@ -362,6 +346,7 @@ mixin _MessageSequence {
     for (var i = 0; i < messages.length; i++) {
       _processMessage(i);
     }
+    if (middleMessage == messages.length) middleItem = items.length;
   }
 }