inbox, topic_list [nfc]: Pull out InboxRowMarkerIcon helper widget

Author: chrisbobbe

lib/widgets/inbox.dart

@@ -612,13 +612,7 @@ class InboxTopicItem extends StatelessWidget {
                       // this Align shrink-wraps to its child's height.)
                       alignment: .centerEnd,
                       child: topic.isResolved
-                        ? InlineIcon(
-                            // Compare icon style in the topic list; probably these
-                            // should stay in sync.
-                            icon: ZulipIcons.check,
-                            fontSize: InboxRowTrailingMarkers.fontSize,
-                            textScaler: MediaQuery.textScalerOf(context).clamp(maxScaleFactor: 1.5),
-                            color: DesignVariables.of(context).textMessage.withFadedAlpha(0.4))
+                        ? InboxRowMarkerIcon(icon: ZulipIcons.check)
                         : null)),
                   SizedBox(width: 8),
                   Expanded(child: Padding(
@@ -649,6 +643,38 @@ class InboxTopicItem extends StatelessWidget {
   }
 }
 
+/// An [InlineIcon] styled for use as a marker in inbox rows.
+///
+/// This encapsulates style details that should stay in sync
+/// across the inbox and topic-list pages.
+class InboxRowMarkerIcon extends StatelessWidget {
+  const InboxRowMarkerIcon({
+    super.key,
+    required this.icon,
+    this.visible = true,
+    this.padBefore = false,
+    this.padAfter = false,
+  });
+
+  final IconData icon;
+  final bool visible;
+  final bool padBefore;
+  final bool padAfter;
+
+  @override
+  Widget build(BuildContext context) {
+    return InlineIcon(
+      icon: icon,
+      fontSize: InboxRowTrailingMarkers.fontSize,
+      textScaler: MediaQuery.textScalerOf(context).clamp(maxScaleFactor: 1.5),
+      color: DesignVariables.of(context).textMessage.withFadedAlpha(0.4),
+      visible: visible,
+      padBefore: padBefore,
+      padAfter: padAfter,
+    );
+  }
+}
+
 /// A short, baseline-aligned row, optionally containing
 /// an unread badge, @ icon, and topic visibility icon.
 ///
@@ -670,13 +696,7 @@ class InboxRowTrailingMarkers extends StatelessWidget {
   static const fontSize = 17.0;
 
   Widget _buildIcon(BuildContext context, IconData icon, {required bool padAfter}) {
-    return InlineIcon(
-      icon: icon,
-      fontSize: fontSize,
-      textScaler: MediaQuery.textScalerOf(context).clamp(maxScaleFactor: 1.5),
-      color: DesignVariables.of(context).textMessage.withFadedAlpha(0.4),
-      padAfter: padAfter,
-    );
+    return InboxRowMarkerIcon(icon: icon, padAfter: padAfter);
   }
 
   @override

lib/widgets/topic_list.dart

@@ -8,7 +8,6 @@ import '../model/topics.dart';
 import '../model/unreads.dart';
 import 'action_sheet.dart';
 import 'app_bar.dart';
-import 'color.dart';
 import 'icons.dart';
 import 'inbox.dart';
 import 'message_list.dart';
@@ -279,14 +278,9 @@ class _TopicItem extends StatelessWidget {
                 crossAxisAlignment: .baseline,
                 textBaseline: localizedTextBaseline(context),
                 children: [
-                  InlineIcon(
-                    // Compare icon style in the inbox; probably these
-                    // should stay in sync.
-                    visible: topic.isResolved,
+                  InboxRowMarkerIcon(
                     icon: ZulipIcons.check,
-                    fontSize: InboxRowTrailingMarkers.fontSize,
-                    textScaler: MediaQuery.textScalerOf(context).clamp(maxScaleFactor: 1.5),
-                    color: DesignVariables.of(context).textMessage.withFadedAlpha(0.4)),
+                    visible: topic.isResolved),
                   Expanded(child: Opacity(
                     opacity: opacity,
                     child: Text(