store [nfc]: Move queueId to PerAccountStore

This is an NFC because UpdateMachine would have thrown
(before this change) when the null-check is not on PerAccountStore.

This queueId will later be used for local-echoing.

Author: PIG208

lib/model/store.dart

@@ -333,11 +333,19 @@ class PerAccountStore extends ChangeNotifier with EmojiStore, UserStore, Channel
     connection ??= globalStore.apiConnectionFromAccount(account);
     assert(connection.zulipFeatureLevel == account.zulipFeatureLevel);
 
+    final queueId = initialSnapshot.queueId;
+    if (queueId == null) {
+      // The queueId is optional in the type, but should only be missing in the
+      // case of unauthenticated access to a web-public realm.  We authenticated.
+      throw Exception("bad initial snapshot: missing queueId");
+    }
+
     final realmUrl = account.realmUrl;
     final channels = ChannelStoreImpl(initialSnapshot: initialSnapshot);
     return PerAccountStore._(
       globalStore: globalStore,
       connection: connection,
+      queueId: queueId,
       realmUrl: realmUrl,
       realmWildcardMentionPolicy: initialSnapshot.realmWildcardMentionPolicy,
       realmMandatoryTopics: initialSnapshot.realmMandatoryTopics,
@@ -381,6 +389,7 @@ class PerAccountStore extends ChangeNotifier with EmojiStore, UserStore, Channel
   PerAccountStore._({
     required GlobalStore globalStore,
     required this.connection,
+    required this.queueId,
     required this.realmUrl,
     required this.realmWildcardMentionPolicy,
     required this.realmMandatoryTopics,
@@ -420,6 +429,7 @@ class PerAccountStore extends ChangeNotifier with EmojiStore, UserStore, Channel
   final GlobalStore _globalStore;
   final ApiConnection connection; // TODO(#135): update zulipFeatureLevel with events
 
+  final String queueId;
   UpdateMachine? get updateMachine => _updateMachine;
   UpdateMachine? _updateMachine;
   set updateMachine(UpdateMachine? value) {
@@ -997,12 +1007,7 @@ class UpdateMachine {
   UpdateMachine.fromInitialSnapshot({
     required this.store,
     required InitialSnapshot initialSnapshot,
-  }) : queueId = initialSnapshot.queueId ?? (() {
-         // The queueId is optional in the type, but should only be missing in the
-         // case of unauthenticated access to a web-public realm.  We authenticated.
-         throw Exception("bad initial snapshot: missing queueId");
-       })(),
-       lastEventId = initialSnapshot.lastEventId {
+  }) : lastEventId = initialSnapshot.lastEventId {
     store.updateMachine = this;
   }
 
@@ -1068,7 +1073,6 @@ class UpdateMachine {
   }
 
   final PerAccountStore store;
-  final String queueId;
   int lastEventId;
 
   bool _disposed = false;
@@ -1209,7 +1213,7 @@ class UpdateMachine {
         final GetEventsResult result;
         try {
           result = await getEvents(store.connection,
-            queueId: queueId, lastEventId: lastEventId);
+            queueId: store.queueId, lastEventId: lastEventId);
           if (_disposed) return;
         } catch (e, stackTrace) {
           if (_disposed) return;

test/model/store_test.dart

@@ -673,7 +673,7 @@ void main() {
         ..method.equals('GET')
         ..url.path.equals('/api/v1/events')
         ..url.queryParameters.deepEquals({
-          'queue_id': updateMachine.queueId,
+          'queue_id': store.queueId,
           'last_event_id': lastEventId.toString(),
         });
     }
@@ -838,7 +838,7 @@ void main() {
 
     void prepareExpiredEventQueue() {
       connection.prepare(apiException: eg.apiExceptionBadEventQueueId(
-        queueId: updateMachine.queueId));
+        queueId: store.queueId));
     }
 
     Future<void> prepareHandleEventError() async {

test/widgets/message_list_test.dart

@@ -159,7 +159,7 @@ void main() {
       updateMachine.poll();
 
       updateMachine.debugPrepareLoopError(
-        eg.apiExceptionBadEventQueueId(queueId: updateMachine.queueId));
+        eg.apiExceptionBadEventQueueId(queueId: store.queueId));
       updateMachine.debugAdvanceLoop();
       await tester.pump();
       // Event queue has been replaced; but the [MessageList] hasn't been