Skip to content

Commit 5fb051c

Browse files
chrisbobbegnprice
authored andcommitted
deps: Slight upgrade of Sentry.
Done with the following command: yarn upgrade -- $(tools/deps | grep sentry) && yarn yarn-deduplicate && yarn (See discussion [0].) When `pod install` ran from the postinstall script, I got this error: ``` [!] CocoaPods could not find compatible versions for pod "Sentry": In snapshot (Podfile.lock): Sentry (= 4.4.3, ~> 4.4.0) In Podfile: RNSentry (from `../node_modules/@sentry/react-native`) was resolved to 1.6.3, which depends on Sentry (~> 5.1.8) Specs satisfying the `Sentry (= 4.4.3, ~> 4.4.0), Sentry (~> 5.1.8)` dependency were found, but they required a higher minimum deployment target. ``` Just running `pod update RNSentry` was enough to let `pod install` run without errors the next time. I didn't pin down precisely what the reported change in minimum deployment target was. In fact, between 4.4.0 and 5.1.8 of Sentry, I don't see *any* change to `s.ios.deployment_target` in the Podspec file [1] that gets processed and hosted by CocoaPods as JSON, nor did I see changes to `platforms.ios` in the JSON itself [2] [3]. But the current Podspec there has "8.0" for that value, which is quite safe, as our deployment target (project > ZulipMobile > Info in Xcode) is 10.3, and in any case, it works. The idea to run `pod update RNSentry` came from a comment [4] on CocoaPods/CocoaPods#4373. [0] https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/changes.20in.20generatedEs3.2Ejs/near/935892 [1] getsentry/sentry-cocoa@4.4.0...5.1.8#diff-90b813c6043692fcb10d7f0efa7cbf19 [2] https://github.com/CocoaPods/Specs/blob/master/Specs/a/b/d/Sentry/4.4.0/Sentry.podspec.json [3] https://github.com/CocoaPods/Specs/blob/master/Specs/a/b/d/Sentry/5.1.8/Sentry.podspec.json [4] CocoaPods/CocoaPods#4373 (comment)
1 parent 01cf598 commit 5fb051c

File tree

2 files changed

+190
-1381
lines changed

2 files changed

+190
-1381
lines changed

ios/Podfile.lock

+7-7
Original file line numberDiff line numberDiff line change
@@ -272,19 +272,19 @@ PODS:
272272
- React
273273
- RNDeviceInfo (0.21.5):
274274
- React
275-
- RNSentry (1.0.9):
275+
- RNSentry (1.6.3):
276276
- React
277-
- Sentry (~> 4.4.0)
277+
- Sentry (~> 5.1.8)
278278
- RNSound (0.11.0):
279279
- React
280280
- RNSound/Core (= 0.11.0)
281281
- RNSound/Core (0.11.0):
282282
- React
283283
- RNVectorIcons (6.6.0):
284284
- React
285-
- Sentry (4.4.3):
286-
- Sentry/Core (= 4.4.3)
287-
- Sentry/Core (4.4.3)
285+
- Sentry (5.1.10):
286+
- Sentry/Core (= 5.1.10)
287+
- Sentry/Core (5.1.10)
288288
- Toast (4.0.0)
289289
- UMAppLoader (1.0.2)
290290
- UMBarCodeScannerInterface (5.1.0)
@@ -547,10 +547,10 @@ SPEC CHECKSUMS:
547547
rn-fetch-blob: f525a73a78df9ed5d35e67ea65e79d53c15255bc
548548
RNCAsyncStorage: 3c304d1adfaea02ec732ac218801cb13897aa8c0
549549
RNDeviceInfo: e7c5fcde13d40e161d8a27f6c5dc69c638936002
550-
RNSentry: 2803ba8c8129dcf26b79e9b4d8c80168be6e4390
550+
RNSentry: ae1e005e4f2655775475445a9c49c1d343e8e3a7
551551
RNSound: da030221e6ac7e8290c6b43f2b5f2133a8e225b0
552552
RNVectorIcons: 0bb4def82230be1333ddaeee9fcba45f0b288ed4
553-
Sentry: 14bdd673870e8cf64932b149fad5bbbf39a9b390
553+
Sentry: 8715e88b813bde9ad37aead365d5b04ac7302153
554554
Toast: 91b396c56ee72a5790816f40d3a94dd357abc196
555555
UMAppLoader: ee77a072f9e15128f777ccd6d2d00f52ab4387e6
556556
UMBarCodeScannerInterface: 9dc692b87e5f20fe277fa57aa47f45d418c3cc6c

0 commit comments

Comments
 (0)