boxes/core/views: Add message links in MsgInfoView.

Tests amended.

Author: preetmishra

tests/ui/test_ui_tools.py

@@ -1366,7 +1366,7 @@ def mock_external_classes(self, mocker, monkeypatch, message_fixture):
                             return_value=(64, 64))
         mocker.patch(VIEWS + ".urwid.SimpleFocusListWalker", return_value=[])
         self.msg_info_view = MsgInfoView(self.controller, message_fixture,
-                                         'Message Information')
+                                         'Message Information', OrderedDict())
 
     def test_keypress_any_key(self):
         key = "a"
@@ -1428,7 +1428,7 @@ def test_height_noreactions(self):
     def test_height_reactions(self, message_fixture, to_vary_in_each_message):
         varied_message = dict(message_fixture, **to_vary_in_each_message)
         self.msg_info_view = MsgInfoView(self.controller, varied_message,
-                                         'Message Information')
+                                         'Message Information', OrderedDict())
         # 9 = 3 labels + 1 blank line + 1 'Reactions' (category) + 4 reactions.
         expected_height = 9
         assert self.msg_info_view.height == expected_height

zulipterminal/core.py

@@ -2,6 +2,7 @@
 import signal
 import sys
 import time
+from collections import OrderedDict
 from functools import partial
 from platform import platform
 from typing import Any, List, Optional, Tuple
@@ -134,9 +135,12 @@ def show_help(self) -> None:
         help_view = HelpView(self, "Help Menu (up/down scrolls)")
         self.show_pop_up(help_view)
 
-    def show_msg_info(self, msg: Message) -> None:
+    def show_msg_info(self, msg: Message,
+                      message_links: 'OrderedDict[str, Tuple[str, int]]',
+                      ) -> None:
         msg_info_view = MsgInfoView(self, msg,
-                                    "Message Information (up/down scrolls)")
+                                    "Message Information (up/down scrolls)",
+                                    message_links)
         self.show_pop_up(msg_info_view)
 
     def show_stream_info(self, color: str, name: str, desc: str) -> None:

zulipterminal/ui_tools/boxes.py

@@ -885,7 +885,8 @@ def keypress(self, size: urwid_Size, key: str) -> Optional[str]:
             write_box.msg_write_box.set_edit_pos(len(msg))
             self.model.controller.view.middle_column.set_focus('footer')
         elif is_command_key('MSG_INFO', key):
-            self.model.controller.show_msg_info(self.message)
+            self.model.controller.show_msg_info(self.message,
+                                                self.message_links)
         return key
 
 

zulipterminal/ui_tools/views.py

@@ -1,5 +1,6 @@
 import threading
 import time
+from collections import OrderedDict
 from typing import Any, Callable, Dict, List, Optional, Sequence, Tuple, Union
 
 import urwid
@@ -973,14 +974,20 @@ def __init__(self, controller: Any, color: str,
 
 
 class MsgInfoView(PopUpView):
-    def __init__(self, controller: Any, msg: Message, title: str) -> None:
+    def __init__(self, controller: Any, msg: Message, title: str,
+                 message_links: 'OrderedDict[str, Tuple[str, int]]') -> None:
         self.msg = msg
 
         msg_info = [
             ('', [('Date & Time', time.ctime(msg['timestamp'])[:-5]),
                   ('Sender', msg['sender_full_name']),
                   ('Sender\'s Email ID', msg['sender_email'])]),
         ]
+        if message_links:
+            msg_info.append(('Message Links', [
+                urwid.Text(['{}: {}'.format(index, text), '\n', link])
+                for link, (text, index) in message_links.items()
+            ]))
         if msg['reactions']:
             reactions = sorted(
                 (reaction['emoji_name'], reaction['user']['full_name'])