webhook tests

Author: zurfyx

src/controllers/webhook.js

@@ -1,15 +1,12 @@
 import { chain } from '~/helpers/promise';
 import { githubWebhook } from '~/services/webhook';
 
-export const github = (info, params) => {
+export const github = (info) => {
   // TODO: restrict to GitHub IPs only.
+  // TODO. Restrict to exact URL to avoid duplicated requests with URL variants.
   return chain
+    .then(() => githubWebhook(info))
     .then(() => {
-      // A trivial way to avoid duplicates is to restrict the URL to a single one (no parameters).
-      // GitHub already prevents duplicates.
-      if (!(Object.keys(params).length === 0 && params.constructor === Object)) {
-        throw 'GitHub webhooks URL can\'t have params.';
-      }
-    })
-    .then(() => githubWebhook(info));
+      return { message: 'OK' };
+    });
 }

src/routes/index.js

@@ -97,7 +97,7 @@ router.delete('/messages/:_id', isAuthenticated, isMessageIdValid, isMessageOwne
 /**
  * Webhooks
  */
-router.post('/webhooks/github', c(webhook.github, (req) => [req.body, req.query]));
+router.post('/webhooks/github', c(webhook.github, (req) => [req.body]));
 
 /**
  * Default.

src/services/webhook.js

@@ -25,6 +25,5 @@ export function githubWebhook(info) {
     default: return; // Given action is not supported yet (exit without saving).
   }
 
-  console.info(webhook);
   return webhook.save();
 }

test/api/webhook.js

@@ -0,0 +1,45 @@
+import { expect } from 'chai';
+
+import Webhook from '~/models/Webhook';
+
+describe('Webhook', () => {
+  describe('POST /webhooks/github', () => {
+    // it('should return an error if the url contains parameters', (done) => {
+    //   request
+    //     .post(`${server}/webhooks/github?`)
+    //     .send({ data: 'lots of github data' })
+    //     .end((err, res) => {
+    //       expect(res.status).to.equal(500);
+    //       expect(res.body.message).to.equal('Provided GitHub webhooks URL is invalid');
+    //     });
+    // });
+
+    it('should create a Webhook entry if the request is valid (comment test)', (done) => {
+      request
+        .post(`${server}/webhooks/github`)
+        .send({ 
+          action: 'created', 
+          repository: { full_name: 'github/repo' },
+          issue: {
+            number: 1,
+            title: 'issueTitle',
+            user: { login: 'issueUser' },
+          },
+          comment: {
+            id: 111,
+            user: { login: 'commentUser' },
+            body: 'body',
+          },
+        })
+        .end((err, res) => {
+          expect(res.status).to.equal(200);
+          expect(res.body).to.eql({ message: 'OK' });
+          Webhook.findOne({}).exec().then((webhook) => {
+            expect(webhook.github.repository).to.equal('github/repo');
+            expect(webhook.github.action).to.equal('created');
+            done();
+          });
+        });
+    });
+  });
+});