Skip to content

build(boring-sys): add loongarch conditional compilation patch - #108

Merged
0x676e67 merged 1 commit into
masterfrom
build
Dec 23, 2025
Merged

build(boring-sys): add loongarch conditional compilation patch#108
0x676e67 merged 1 commit into
masterfrom
build

Conversation

@0x676e67

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the build process by introducing conditional compilation for a loongarch specific patch. This ensures that the boringssl-loongarch.patch is only applied when building for the loongarch64 architecture, thereby optimizing the build system and preventing irrelevant patch applications on other platforms.

Highlights

  • Conditional Patch Application: The boringssl-loongarch.patch is now applied conditionally, specifically for the loongarch64 target architecture.
  • Build System Optimization: This change prevents the loongarch patch from being applied unnecessarily on other architectures, streamlining the build process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@0x676e67 0x676e67 changed the title build: add loongarch conditional compilation patch build(boring-sys): add loongarch conditional compilation patch Dec 23, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds a conditional compilation flag to the build script. This ensures that the LoongArch-specific patch is only applied when the compilation target is loongarch64. This change improves the build process by preventing an unnecessary and potentially problematic patch application on other architectures. The implementation is clean and follows idiomatic Rust practices.

@0x676e67
0x676e67 merged commit 29b457c into master Dec 23, 2025
26 checks passed
@0x676e67
0x676e67 deleted the build branch December 23, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant