Updates + future requirements for ADCS checks #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added netexec - added certipy (no checks done yet) - added RunAs, so no credentials need to be pasted - Some changes to README, to run all the different binaries with the correct python version. Certipy doesn't work with the newest python.
readability README
… into improvements
Improvements
Fixed paths added ESC checks with certipy
|
Added ESC checks |
|
Sorry still have to take a look at this as discussed personally with you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some changes to README, to add the new setup steps and made it more readable, by adding dropdown menu's.
Tested the new setup with a colleague, to check if setup steps were missed. Some were not clear, added more information.
Check in GOAD environment and all looks good and working. Only thing which will give issues, is the RunAs, because it runs as a different user, so NetExec, Certipy and the Python exe won't be tested correctly. A static path can be inserted, but it doesn't give any issues, because non of those files are required for powerupsql