Skip to content

refactor(stark): rename parallel -> concurrent feature and add it to default set#1073

Merged
Nashtare merged 1 commit into
nextfrom
robin/concurrent
Jun 25, 2026
Merged

refactor(stark): rename parallel -> concurrent feature and add it to default set#1073
Nashtare merged 1 commit into
nextfrom
robin/concurrent

Conversation

@Nashtare

Copy link
Copy Markdown
Contributor

Describe your changes

Two things:

  • rename the parallel feature of miden-lifted-stark to concurrent to be consistent across the Miden ecosystem and this repo
  • make it a default feature. This is to align it with miden-crypto and to make it less obvious to miss for downstream users that would need to pull in both miden-crypto and miden-lifted-stark as dependencies.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

@Nashtare Nashtare requested review from adr1anh and huitseeker June 24, 2026 10:57
@Nashtare Nashtare changed the title refactor: rename parallel -> concurrent feature and add it to default set refactor(stark): rename parallel -> concurrent feature and add it to default set Jun 24, 2026
@Nashtare Nashtare force-pushed the robin/concurrent branch 3 times, most recently from a25113f to 8779bbf Compare June 24, 2026 11:22

@adr1anh adr1anh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for catching this!

@huitseeker huitseeker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@Nashtare Nashtare merged commit 3402098 into next Jun 25, 2026
28 checks passed
@Nashtare Nashtare deleted the robin/concurrent branch June 25, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants