fix: add missing list validation for sync_transactions and remove inc…#1687
Merged
Mirko-von-Leipzig merged 3 commits intoFeb 19, 2026
Merged
Conversation
…orrect RPC limits sync_transactions was the only endpoint with a repeated list param that wasn't validated at the RPC layer. also removed misleading RPC_LIMITS entries for SyncAccountVault and SyncAccountStorageMaps since they take a single account_id, not a list.
drahnr
approved these changes
Feb 18, 2026
drahnr
added
the
no changelog
Contributor
|
Please adjust the CI check for the get limits endpoint |
Contributor
|
Running |
Contributor
Author
|
fixed - updated the get_limits test assertions. also ran clippy. will use Makefile checks next time, thanks for the heads up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noticed while reading through the rpc code that sync_transactions was missing the account_ids list validation at the RPC layer - all other endpoints with repeated list params already had this check. the store layer was validating it, but requests should be rejected early at the RPC boundary.
also removed the RPC_LIMITS entries for SyncAccountVault and SyncAccountStorageMaps since they accept a single account_id, not a repeated list - having list limits for them was misleading for clients calling get_limits.
partially addresses #1080
cargo check passes.