fix: Block proof request serialization#2280
Open
sergerad wants to merge 4 commits into
Open
Conversation
sergerad
commented
Jun 24, 2026
| /// serialized layout is `tx_batches`, then `block_header`, then `block_inputs`. This crate also | ||
| /// builds for `wasm32` (where `miden-node-proto`, via tonic transport / tokio net, does not | ||
| /// compile), so it cannot depend on that type and instead mirrors its layout here. Keep this in | ||
| /// sync with `BlockProofRequest`'s `Serializable` impl. |
Collaborator
Author
There was a problem hiding this comment.
@Mirko-von-Leipzig any suggestions as to how to handle this better? Can't use BlockProofRequest from miden-node-proto because this crate needs wasm compilation
Collaborator
There was a problem hiding this comment.
Yes - we delete all this.
See #995 (comment).
cc @SantiagoPittella - could we just delete this client crate now? I think so..
Collaborator
There was a problem hiding this comment.
Yes, I think we can delete it
Mirko-von-Leipzig
approved these changes
Jun 24, 2026
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
Collaborator
There was a problem hiding this comment.
LGTM; but we really should remove this crate imo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ser/de mismatch for block proving requests.
Changelog