ci: split chrome e2e per-network for nightly + node-monitor symmetry#228
Draft
WiktorStarczewski wants to merge 2 commits intomainfrom
Draft
ci: split chrome e2e per-network for nightly + node-monitor symmetry#228WiktorStarczewski wants to merge 2 commits intomainfrom
WiktorStarczewski wants to merge 2 commits intomainfrom
Conversation
Replaces the multi-network e2e-blockchain.yml with three workflows that match how the wallet is actually monitored downstream — the network- monitor exists in devnet and testnet flavors, and each only cares about its own network's nightly result. - e2e-blockchain-chrome-devnet.yml: chrome devnet only, push + nightly (04:00 UTC) + workflow_dispatch. Auto-creates a tracking issue on scheduled-run failures (push reds stay on the merge commit). - e2e-blockchain-chrome-testnet.yml: chrome testnet only, same shape. - e2e-blockchain-mobile.yml: iOS lanes (renamed from e2e-blockchain.yml, mobile sections only). Push trigger only — macOS minutes are 10x and the on-push cadence is enough. Trade-off: the previous 'AT LEAST ONE network passed' merge tolerance inside a single chrome workflow no longer exists, since each network is its own workflow now. If you want that tolerance preserved at the merge gate, configure branch protection so neither devnet nor testnet is a hard required check; the network-monitor cards carry the day-to-day visibility. Companion: 0xMiden/node nightly-card PR.
5 tasks
Reviewer feedback: per-network split removed the 'AT LEAST ONE network
passed' merge tolerance for main pushes — single-network protocol
mismatches (devnet ahead of pinned SDK, etc) would suddenly block merges
they previously didn't.
Restructured to four chrome+mobile workflows by purpose:
e2e-blockchain-chrome.yml — push-only, both networks + gate
e2e-blockchain-chrome-devnet.yml — schedule-only, devnet
e2e-blockchain-chrome-testnet.yml — schedule-only, testnet
e2e-blockchain-mobile.yml — push-only, iOS lanes (unchanged)
The schedule-only per-network workflows feed the network-monitor cards
(devnet monitor pins to chrome-devnet, testnet monitor pins to
chrome-testnet). The push workflow keeps the OR-gate for merge
protection. No cross-trigger duplication: chrome.yml runs on push,
chrome-{devnet,testnet}.yml run on schedule, neither double-fires.
Trade-off settled: tolerance preserved for merge gating, per-network
visibility preserved for monitoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits
e2e-blockchain.ymlinto four workflows so chrome push-coverage and per-network nightly coverage can each have their own trigger and own gate strategy. The split is what unlocks the symmetric per-network nightly CI card in0xMiden/node, while keeping the existing OR-tolerance gate for main-push merges.Changes
e2e-blockchain-chrome.yml(new)e2e-blockchain-chrome-devnet.yml(new)0 4 * * *+ workflow_dispatche2e-blockchain-chrome-testnet.yml(new)0 4 * * *+ workflow_dispatche2e-blockchain-mobile.yml(renamed frome2e-blockchain.yml, mobile-only)The two nightly per-network workflows auto-create a
ci-failure/nightly-e2eissue on schedule failure (push reds stay on the merge commit; PR/workflow_dispatchreds don't open issues either).Why four files
Two requirements pulling in different directions:
e2e-blockchain-chrome.yml(push-only).e2e-blockchain-chrome-{devnet,testnet}.yml(schedule-only) carry this.No cross-trigger duplication:
e2e-blockchain-chrome.ymlruns on push, the per-network siblings run on schedule. They don't both fire on the same event.Companion PR
0xMiden/node#2050 — adds the
nightly_cicard to the network-monitor that consumes the scheduled per-network runs.Test plan
e2e-blockchain-chrome.ymlruns both lanes, gate evaluates OR-tolerance,e2e-blockchain-mobile.ymlruns iOS lanese2e-blockchain-chrome-devnet.ymlore2e-blockchain-chrome-testnet.ymlworkflow_dispatchwith intentionally broken commit on a per-network workflow) → tracking issue created withnightly-e2elabelworkflow_dispatchruns do NOT create a tracking issue