Skip to content

Conversation

arnaucube
Copy link
Collaborator

No description provided.

…10% and then 2x to avoid miners rejection), etc
Copy link
Collaborator

@ax0 ax0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…the case were the rpc node has reached the maximum rate and just blocks any new call, but this commit switches it to returning the error to the upper layer, so that the server does not stop running
Copy link
Collaborator

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me but I spotted a bug, check it out.
I noticed a few dbg! and println; maybe you could replace them by logs with debug!, and info! ?

@arnaucube arnaucube force-pushed the improve-eth-txs branch 2 times, most recently from 387179f to 99411e0 Compare September 22, 2025 09:41
Copy link
Collaborator

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arnaucube arnaucube merged commit f481c4d into main Sep 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants