Add a variation of the Safe{Wallet} Guard timelock for Safe{Wallet} version 1.4.1 #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🛡️ Immunefi PR ReviewsWe’ve assigned 5 code reviewer(s) to this PR. They’ll begin the review shortly and leave feedback directly in the pull request. This review is based on the current state of your pull request. If you make changes after the review starts, they won’t be reflected here. To ensure the review includes your latest updates, you’ll need to open a new pull request. |
![immunefi-magnus[bot]](https://avatars.githubusercontent.com/in/1208986?s=60&v=4){kind=small}
| } | ||
|
|
||
| function _checkAfterExecution(ISafeMinimal _safe) private { | ||
| function _checkAfterExecutionReturnBool(ISafeMinimal _safe) internal view returns (bool result) { |
There was a problem hiding this comment.
I would recommend to add comment above this function, that this is rewritten _checkAfterExecution function, but that returns bool value instead of revert
- OxStrausses
| pragma solidity =0.8.25; | ||
|
|
||
| // This enum is derived from the code deployed to 0xfb1bffC9d739B8D520DaF37dF666da4C687191EA | ||
| import {IERC165} from "@forge-std/interfaces/IERC165.sol"; |
There was a problem hiding this comment.
For contract that are going to be deployed better to import from OpenZeppelin.
- OxStrausses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.