Skip to content

feat: prove_transaction L2→L1 messages, ProofMode::None behavior change #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3alpha merged 7 commits into from
Apr 9, 2026
Merged

feat: prove_transaction L2→L1 messages, ProofMode::None behavior change #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8379968
feat: extract L2→L1 messages in prove_transaction via simulation
3alpha Apr 8, 2026
a4ad86e
feat(proofs): bind L2→L1 messages into proof and error on execution f…
3alpha Apr 9, 2026
dc26f96
Update number of expected proof fact elements for devnet tx
3alpha Apr 9, 2026
85522b2
bugfix: align prove message sender
3alpha Apr 9, 2026
c236cf2
Remove skip validate flag, i.e. require correct tx signature for proving
3alpha Apr 9, 2026
da1c112
Skip stripping signature when creating proof bearing tx
3alpha Apr 9, 2026
d4c57ba
Ensure that proof and proof facts differ for different blocks
3alpha Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/starknet-devnet-core/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,8 @@ pub enum ProvingError {
NoVirtualProgramHashesAllowed,
#[error("Block Id provided doesn't match existing block")]
InvalidBlockId,
#[error("Transaction execution failed: {0}")]
TransactionExecutionFailed(String),
#[error("Error: {0}")]
Other(String),
}
Expand Down
9 changes: 1 addition & 8 deletions crates/starknet-devnet-core/src/starknet/add_invoke_transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,9 @@ pub fn add_invoke_transaction(
});
}

let mut sn_api_transaction =
let sn_api_transaction =
broadcasted_invoke_transaction.create_sn_api_invoke(&starknet.chain_id().to_felt())?;

if starknet.config.proof_mode == ProofMode::None {
if let starknet_api::transaction::InvokeTransaction::V3(tx_v3) = &mut sn_api_transaction.tx
{
tx_v3.proof_facts = Default::default();
}
}

let transaction_hash = sn_api_transaction.tx_hash.0;

let invoke_transaction = match broadcasted_invoke_transaction {
Expand Down
5 changes: 3 additions & 2 deletions crates/starknet-devnet-core/src/starknet/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ use starknet_types::emitted_event::EmittedEvent;
use starknet_types::felt::{
BlockHash, ClassHash, ProofFacts, TransactionHash, felt_from_prefixed_hex, split_biguint,
};
use starknet_types::messaging::OrderedMessageToL1;
use starknet_types::num_bigint::BigUint;
use starknet_types::patricia_key::PatriciaKey;
use starknet_types::proof::Proof;
Expand Down Expand Up @@ -943,10 +944,10 @@ impl Starknet {
}

pub fn prove_transaction(
&self,
&mut self,
block_id: CustomBlockId,
invoke_transaction: BroadcastedInvokeTransaction,
) -> DevnetResult<(Proof, ProofFacts)> {
) -> DevnetResult<(Proof, ProofFacts, Vec<OrderedMessageToL1>)> {
match self.config.proof_mode {
ProofMode::Devnet => proofs::prove_transaction(self, block_id, invoke_transaction),
_ => Err(Error::UnsupportedAction {
Expand Down
Loading
Loading