Skip to content

virtual external functions are public #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Agusx1211 merged 1 commit into from
Dec 4, 2024
Merged

virtual external functions are public #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/contracts/tokens/ERC1155/ERC1155.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ contract ERC1155 is IERC1155, ERC165 {
* @param _approved True if the operator is approved, false to revoke approval
*/
function setApprovalForAll(address _operator, bool _approved)
external virtual override
public virtual override
{
// Update operator status
operators[msg.sender][_operator] = _approved;
Expand Down
2 changes: 1 addition & 1 deletion src/contracts/tokens/ERC1155PackedBalance/ERC1155PackedBalance.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ contract ERC1155PackedBalance is IERC1155, ERC165 {
* @param _approved True if the operator is approved, false to revoke approval
*/
function setApprovalForAll(address _operator, bool _approved)
external virtual override
public virtual override
{
// Update operator status
operators[msg.sender][_operator] = _approved;
Expand Down
2 changes: 1 addition & 1 deletion src/contracts/tokens/ERC2981/ERC2981Global.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ contract ERC2981Global is IERC2981, ERC165 {
function royaltyInfo(
uint256,
uint256 _saleCost
) external view virtual override returns (address receiver, uint256 royaltyAmount) {
) public view virtual override returns (address receiver, uint256 royaltyAmount) {
FeeInfo memory info = globalRoyaltyInfo;
return (info.receiver, _saleCost * info.feeBasisPoints / 1000);
}
Expand Down
Loading