🐛 Don't render manually created custom element twice

11ways · Mar 12, 2024 · f44c724 · f44c724
1 parent 5894ba1
commit f44c724
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 * Fix setting `value` property on a `<select>` item not changing the selected option
 * Make the `each` expression handle `Map`-like instances correctly
 * Fix `each` expression not supporting function calls
+* Don't render manually created custom element on initial attachment to the DOM if it has already been manually rendered
 
 ## 2.3.18 (2024-02-25)
 

diff --git a/lib/element/custom_element.js b/lib/element/custom_element.js
@@ -2025,7 +2025,7 @@ Element.setMethod(function updateRenderedTime() {
  *
  * @author   Jelle De Loecker <[email protected]>
  * @since    1.1.2
- * @version  2.3.15
+ * @version  2.3.19
  */
 Element.setMethod(function connectedCallback() {
 
@@ -2082,7 +2082,7 @@ Element.setMethod(function connectedCallback() {
 				that.emit('rendered', {bubbles: false});
 			}
 
-			if (has_template && that[Hawkejs.CREATED_MANUALLY] && that[Hawkejs.RENDER_CONTENT]) {
+			if (has_template && that[Hawkejs.CREATED_MANUALLY] && that[Hawkejs.RENDER_CONTENT] && !that.has_rendered) {
 
 				let rendering = that[Hawkejs.RENDER_CONTENT]();