Omit errors from analytics when error_details available

changelog: Internal, Analytics, Omit errors from analytics when error_details available
18F · Jan 28, 2025 · 37c882f · 37c882f
1 parent 4eddf18
commit 37c882f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/app/services/form_response.rb b/app/services/form_response.rb
@@ -19,7 +19,7 @@ def success?
 
   def to_h
     hash = { success: success }
-    hash[:errors] = errors.presence if !serialize_error_details_only?
+    hash[:errors] = (!defined?(@error_details) && errors).presence if !serialize_error_details_only?
     hash[:error_details] = flatten_details(error_details) if error_details.present?
     hash.merge!(extra)
     hash

diff --git a/spec/services/form_response_spec.rb b/spec/services/form_response_spec.rb
@@ -179,9 +179,7 @@
         response = FormResponse.new(success: false, errors: errors)
         response_hash = {
           success: false,
-          errors: {
-            email_language: ['Language cannot be blank'],
-          },
+          errors: nil,
           error_details: {
             email_language: { blank: true },
           },
@@ -197,9 +195,7 @@
           response = FormResponse.new(success: false, errors: errors)
           response_hash = {
             success: false,
-            errors: {
-              email_language: [t('errors.messages.blank')],
-            },
+            errors: nil,
             error_details: {
               email_language: { blank: true },
             },
@@ -240,9 +236,7 @@
           response = FormResponse.new(success: false, errors: errors)
           response_hash = {
             success: false,
-            errors: {
-              email_language: ['Language cannot be blank'],
-            },
+            errors: nil,
             error_details: {
               email_language: { blank: true },
             },