Merged
Conversation
Example warning resolved by this change: warning: this returns a `Result<_, ()>` --> oxide-auth/src/primitives/issuer.rs:28:5 | 28 | fn refresh(&mut self, _refresh: &str, _grant: Grant) -> Result<RefreshedToken, ()>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_unit_err Link: https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#result_unit_err Signed-off-by: Abe Kohandel <abe@kodebooth.com>
ekohandel
force-pushed
the
result-unit-error
branch
from
87666e0 to
71dd075
Compare
197g
approved these changes
Jan 28, 2026
Owner
197g
left a comment
197g
left a comment
There was a problem hiding this comment.
Alright. I suppose it's time for that version bump.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.