feat: velocity network did resolution #26
Conversation
|
HI @xaviaracil! |
|
This is good news @sloops77! |
sloops77
force-pushed
the
feat/velocity-network-credential-did-resolution
branch
from
d1df9e7 to
95db6fd
Compare
inspector-vc/pom.xml
Outdated
| @@ -8,6 +8,11 @@ | |||
| <version>1.3.7</version> | |||
| </parent> | |||
| <artifactId>inspector-vc</artifactId> | |||
|
|
|||
| <properties> | |||
| <web3j.version>4.14.0</web3j.version> | |||
There was a problem hiding this comment.
This version throws some errors when compiling with the JDK 17:
[ERROR] class file has wrong version 65.0, should be 61.0
[ERROR] Please remove or make sure it appears in the correct subdirectory of the classpath.
I've tried to downgrade this version to 4.10.3, which has support for JDK 17, but then I got the error:
[ERROR] /Users/xavi/Developer/1EdTech/vc-public-validator/inspector-vc/src/main/java/org/velocitynetwork/contracts/VelocityNetworkMetadataRegistry.java:[546,51] cannot find symbol
symbol: class LinkReference
location: class org.web3j.tx.Contract
There was a problem hiding this comment.
Solved by downgrading it to 4.13.0
| @@ -67,6 +68,21 @@ public class OB30Inspector extends VCInspector implements SubInspector { | |||
| protected final List<Probe<VerifiableCredential>> userProbes; | |||
| protected final String didResolutionUrl; | |||
|
|
|||
| private Map<String, Map<String, String>> velocityNetworkConfigs = Map.of( | |||
There was a problem hiding this comment.
Are you ok to have these values hardwired here?
|
|
||
| import java.util.List; | ||
|
|
||
| public class VelocityNetworkTests { |
There was a problem hiding this comment.
These hardwired data are test data, so it is ok to have it here. Am I right?
No description provided.