Fixed conditional writing of Codable.swift #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts diff check inside write_codable_file will work as expected.
Author
|
Should the Clippy errors be fixed on a separate PR? They are not due to changes made here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved location of newline character generation so that the file contents diff check inside write_codable_file will work as expected.
The Codable.swift file in only supposed to be written to disk if it has changed. Currently, the Codeable.swift file is always being written to disk. This causes problems with Xcode previews. When the typeshare script is run as part of an Xcode preview build, Xcode detects a file change (Codeable.swift) and restarts the compilation in an endless loop.
A previous fix to this bug was made/attempted here: #205.