Fix Mamba TE backlight effects #424 - #966
Open
sivaadityacoder wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #424
Hey! Saw the issue about the Mamba TE being stuck in a strobing rainbow loop, so I dug into it.
The main issue is that the Mamba TE (0x0046) actually handles its lighting through the matrix/backlight methods, rather than the regular mouse logo and scroll LED methods that the app was trying to send.
To fix this, I updated the config in
mamba_te_wired.jsonto tell it to use the backlight target. Then I just added a quick check inRazerDeviceMouseto redirect all the brightness and effect calls over to thekbdbacklight commands if the mouse requires it. Also hid the old mouse effects since they don't do anything for this model anyway.Everything should be working normally now and it actually responds to the lighting changes instead of just doing the rainbow strobe. Let me know if you need me to change anything!
IssueHunt Summary
Referenced issues
This pull request has been submitted to: