This repository was archived by the owner on May 16, 2025. It is now read-only.
feat(content): Legends Quest #1013
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noted-shark
force-pushed
the
legends-quest
branch
2 times, most recently
from
36ebef5 to
566a9c9
Compare
noted-shark
force-pushed
the
legends-quest
branch
2 times, most recently
from
0746454 to
3c5b273
Compare
noted-shark
force-pushed
the
legends-quest
branch
from
4868f61 to
d9b1a86
Compare
|
Read through this draft a bit, I refactored %skill_sound out of skilling entirely (was too convoluted and didnt match old videos). So it probably doesnt exist for the jungle chop scripts |
tannerdino
reviewed
Feb 28, 2025
There was a problem hiding this comment.
You'd prob want to put these items into a category, then have a custom opheld5 script for them. Instead of putting this in the ~dropslot proc? Also curious what ~legends_drop_gem does
tannerdino
reviewed
Feb 28, 2025
| @@ -47,6 +47,10 @@ if (~pvm_debuff_allowed($spell_data) = false) { | |||
| return; | |||
| } | |||
| def_int $duration = ~pvm_spell_cast($spell_data); | |||
| if (~legends_check_spell_usage($spell, $spell_data, $duration) = true) { | |||
There was a problem hiding this comment.
Might be able to just add a check for npc_type right in the apnpct trigger for curse, weaken and confuse, and jump to a special label for legends quest. Similarly to air strike for tutorial island. Prevents the default script from always checking npc_type & spell for all spells
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.