Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/readme #36

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Feat/readme #36

merged 2 commits into from
Feb 10, 2024

Conversation

dsstevens
Copy link
Contributor

@dsstevens dsstevens commented Feb 10, 2024 •
edited
Loading

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor(DRY-ing up/ reorganizing code, etc.)
  • Small fix (Corrected a typo, removed a comment, etc.)

Issue/feature/bug description:

Completed content of Readme, still needs images

Checklist before requesting a review

  • I ran the code locally and verified that there are no visible errors.
  • I have performed a self-review of my code
  • I have refactored my code before this push
  • The commit message follows our guidelines
  • My code follows the code style of this project.

What’s next:

Adding images on Github

@dsstevens dsstevens added the documentation Improvements or additions to documentation label Feb 10, 2024
@dsstevens dsstevens self-assigned this Feb 10, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
laboulangerie ✅ Ready (Inspect) Visit Preview Feb 10, 2024 6:13pm

@dsstevens dsstevens linked an issue Feb 10, 2024 that may be closed by this pull request
FE: rails repo: Write Readme #27
Closed
rsteckline
rsteckline approved these changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@rsteckline rsteckline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there! Need to work on error handling testing and recipe styling.

@rsteckline rsteckline merged commit a0b9e5a into main Feb 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsteckline rsteckline rsteckline approved these changes

@Captainlearyo Captainlearyo Awaiting requested review from Captainlearyo

Assignees

@dsstevens dsstevens

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FE: rails repo: Write Readme
2 participants
@dsstevens @rsteckline