Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api/new data structure #37

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Api/new data structure #37

merged 2 commits into from
Feb 10, 2024

Conversation

rsteckline
Copy link
Contributor

@rsteckline rsteckline commented Feb 10, 2024

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor(DRY-ing up/ reorganizing code, etc.)
  • Small fix (Corrected a typo, removed a comment, etc.)

Issue/feature/bug description:

Restructuring components to return functionality for new API response

Checklist before requesting a review

  • I ran the code locally and verified that there are no visible errors.
  • I have performed a self-review of my code
  • I have refactored my code before this push
  • The commit message follows our guidelines
  • My code follows the code style of this project.

What’s next:

Testing and redeployment error check

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
laboulangerie ✅ Ready (Inspect) Visit Preview Feb 10, 2024 8:24pm

Copy link
Contributor

@dsstevens dsstevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job restructuring how the application is handling the reformatted API response so that we can better parse out and display the recipe. In part two when we implement a CSS preprocessor, our breakpoints and styling will be more concise and better handled. Thanks for dealing with my breakpoints!

@dsstevens dsstevens merged commit 4425bc2 into main Feb 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants