made warden side partially working #29
Conversation
23abdul23
left a comment
23abdul23
left a comment
There was a problem hiding this comment.
If confused, ask me about more implemntation details
| {/* <Stack.Screen name="Emergency" component={EmergencyScreen} /> */} | ||
| {/* <Stack.Screen name="Profile" component={ProfileScreen} /> */} | ||
| <Stack.Screen name="Scan" component={Scanner} /> | ||
|
|
There was a problem hiding this comment.
why are here these comments when they are not being used.
| required: true, | ||
| unique: true, | ||
| sparse: true, | ||
| }, |
There was a problem hiding this comment.
Device id doesn't make sense we can remove this from every model schema. Because it is possible that someone has logged in to some new device.
Remove all occurances and use of 'deviceID'
| createdAt: { | ||
| fontSize: SIZES.xs, | ||
| color: COLORS.gray[500], | ||
| }, |
There was a problem hiding this comment.
What was the need of making new OUTPASS component , when there was already OutpaasCard.js the component was already their , u need to simply reuse that and modify it a little bit.
what you can do is add a simple code block
if (role == 'student')
...simple outpass card
if (role =='warden')
....add two buttons of Approve and Reject
(Chat GPT / Copilot jo bhi de sb mat use karo)
There was a problem hiding this comment.
Those changes were complex to integrate and warden ka role related to outpass alag h its better uska alag card rhe and maine edit krke hi code use kiya h gpt se :|
| console.log("INCOMING REGISTRATION DATA:", req.body); | ||
| const { name, email, password, studentId, guardId, wardenId, hostel, roomNumber, phoneNumber, securityPost, emergencyContact, gender, year, department, role} = req.body | ||
| const { name, email, password, studentId, guardId, wardenId, hostel, roomNumber, phoneNumber, securityPost, gender, year, department, role, deviceId} = req.body | ||
| let user; |
| } | ||
| }) | ||
|
|
||
|
|
There was a problem hiding this comment.
Check when the outpass are being created , they are still getting auto approved. Change that to pending.
Also there is many not useful routes commented , delete all that is not so useful.
| /> | ||
| </View> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Same outpassScreen.js can be used here also , just update the things as required using (role == 'warden')
Only make new files if introducing minor changes is too difficullt.
There was a problem hiding this comment.
but warden role is different its better uska sb kuch alag rhe in my opinion
| const { user, logout } = useAuth() | ||
|
|
||
| const isStudent = user.role === "student" | ||
| const isWarden = user.role === "warden" |
There was a problem hiding this comment.
this variable is not used anywhere??
There was a problem hiding this comment.
its used below. its usage is to separate components to be displayed in a students profile section and in a warden's profile section. like for a student we want to display the "Academic Info" but we dont want this for warden ...so basically vo neeche ek jagah use horha
| createOutpass: (data) => api.post("/outpass/generate", data), | ||
| updateOutpass: (id, data) => api.put(`/outpass/${id}`, data), | ||
| getHistory: (params) => api.get("/outpass/history", { params }), | ||
| getPendingRequests: () => api.get("/outpass/warden/requests"), |
There was a problem hiding this comment.
do the required changes for the fetchProfile and other api routes , refactor them accordingly.
2 participants
No description provided.