Skip to content

4.3.122

Compare
Choose a tag to compare
@k-anderson k-anderson released this 05 Oct 21:48
· 77 commits to 4.3 since this release
3b69ab7

Generic badge

Changes for 4.3.122

Changes to branch 4.3 after version 4.3.121.

Commits
  • PISTON-1135: compare existing account doc to saved account doc, not req data - by Daniel Finke

    Prior to this change, the check of whether the account’s "pvt_enabled" property changed was always succeeding. This caused the registrations for the account to be flushed on every account save.

  • fix make validate-js - by James Aimonetti

    make validate-js was always failing with

    
    Usage: ./scripts/validate-js.sh file.json+
    
    
  • fix make validate-js - by Daniel Finke

    make validate-js was always failing with

    
    Usage: ./scripts/validate-js.sh file.json+
    
    
  • fix hotornot crash when caller_id_numbers is in filter_list - by Alan R Evans

    Fix hotornot crash when caller_id_names is present in system_config/hotornot/filter_list

    Before fix:

    
    [root@d1k1 ~]# sup hotornot_maintenance rates_for_did 00447800000000
    
    Candidates:
    
    RATE NAME |   COST | INCREMENT |   MINIMUM | SURCHARGE |    WEIGHT |          PREFIX |   RATEDECK NAME |         VERSION |
    
    outbound_GB_447891 | 0.0102 |        60 |        60 |       0.0 |        59 |          447891 |        ratedeck |                 |
    
    outbound_GB_4478 | 0.2237 |        60 |        60 |       0.0 |        18 |            4478 |        ratedeck |                 |
    
    outbound_GB_44 | 0.0035 |        60 |        60 |       0.0 |        20 |              44 |        ratedeck |                 |
    
    inbound_UK_44 |    0.0 |        60 |        60 |       0.0 |        20 |              44 |        ratedeck |                 |
    
    Command failed: {'EXIT',{function_clause,[{knm_converters,normalize,[undefined],[{file,"src/converters/knm_converters.erl"},{line,101}]},{hon_util,matching_rate,3,[{file,"src/hon_util.erl"},{line,213}]},{lists,'-filter/2-lc$^0/1-0-',2,[{file,"lists.erl"},{line,1286}]},{lists,foldl,3,[{file,"lists.erl"},{line,1263}]},{hotornot_maintenance,rates_for_did,4,[{file,"src/hotornot_maintenance.erl"},{line,83}]},{sup,in_kazoo,4,[{file,"src/sup.erl"},{line,98}]},{rpc,'-handle_call_call/6-fun-0-',5,[{file,"rpc.erl"},{line,197}]}]}}
    
    

    After fix:

    
    [root@d1k1 ~]# sup hotornot_maintenance rates_for_did 00447800000000
    
    Candidates:
    
    RATE NAME |   COST | INCREMENT |   MINIMUM | SURCHARGE |    WEIGHT |          PREFIX |   RATEDECK NAME |         VERSION |
    
    outbound_GB_447891 | 0.0102 |        60 |        60 |       0.0 |        59 |          447891 |        ratedeck |                 |
    
    outbound_GB_4478 | 0.2237 |        60 |        60 |       0.0 |        18 |            4478 |        ratedeck |                 |
    
    outbound_GB_44 | 0.0035 |        60 |        60 |       0.0 |        20 |              44 |        ratedeck |                 |
    
    inbound_UK_44 |    0.0 |        60 |        60 |       0.0 |        20 |              44 |        ratedeck |                 |
    
    Matching:
    
    RATE NAME |   COST | INCREMENT |   MINIMUM | SURCHARGE |    WEIGHT |          PREFIX |   RATEDECK NAME |         VERSION |
    
    * outbound_GB_447891 | 0.0102 |        60 |        60 |       0.0 |        59 |          447891 |        ratedeck |                 |
    
    outbound_GB_4478 | 0.2237 |        60 |        60 |       0.0 |        18 |            4478 |        ratedeck |                 |
    
    inbound_UK_44 |    0.0 |        60 |        60 |       0.0 |        20 |              44 |        ratedeck |                 |
    
    outbound_GB_44 | 0.0035 |        60 |        60 |       0.0 |        20 |              44 |        ratedeck |                 |
    
    ok
    
    
  • Upstream 4.3 knm converters normalize crashes - by Ben Bradford

    Crash fixes related to knm_converters:normalize/1

    Kazoo5 PRs:

    2600hz/kazoo-jonny5#4

    2600hz/kazoo-core#54

  • Upstream 4.3 telnyx carrier api issues - by Ben Bradford

    Fixes to the Telnyx carrier module

    The best effort configuration setting did not work, My guess is that this was written and then telnyx changed the api response and the response to no longer included the flag “any_best_effort” so the old code would never filter the best effort out. This improvement will now pass the best effort flag to telnyx and remove the need to filter the response.

    Requests for TF numbers was failing as the request built and passed to Telnyx was incorrect. It passed the TF NAP as prefix in the body and it should be nap as there api doc states. I have also added the option to filer TF numbers by NXX.

    Also found that the crossbar quantity option was always overwritten to 500 so every time you requested 15 numbers through CB it requested 500 from telnyx resulting in longer query times. The fix was to only set the default values if they were not set.

    Kazoo5 PR 2600hz/kazoo-core#48

  • Upstream 4.3 - standardized csv files generated by kazoo - by Ben Bradford

    Back port or changes accepted to master branch a few months back by @jamesaimonetti

    #6446

  • PISTON-1002: use collect_digits for DTMF during vm greeting/instructions - by James Aimonetti

    Backport of #6249. Going to make a change in master as well as the 8-arity version of kapps_call_command:collect_digits wasn't actually needed.

  • PISTON-1002: use collect_digits for DTMF during vm greeting/instructions - by Daniel Finke

    Backport of #6249. Going to make a change in master as well as the 8-arity version of kapps_call_command:collect_digits wasn't actually needed.

  • Moved callflow validation logic out of crossbar and into kazoo core so it can be used by other modules - by Ben Bradford

    Moved validation logic so it can be used by future kazoo tasks callflow module