fix: assign comprehend_client correctly in ComprehendFilterAgent and fix on_llm_start docstring#469
Open
octo-patch wants to merge 1 commit into2FastLabs:mainfrom
Open
Conversation
- ComprehendFilterAgent: use self.comprehend_client (not self.client) when no client is passed, so detect_sentiment/pii/toxicity methods can find it. Fixes 2FastLabs#359 - AgentCallbacks.on_llm_start: correct docstring to match actual parameter names (name instead of agent_name, remove non-existent messages param). Fixes 2FastLabs#360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #359, fixes #360
Problem 1 (fixes #359)
When
ComprehendFilterAgentis initialized without aclientoption, the constructor assigned the boto3 client toself.clientinstead ofself.comprehend_client. All detection methods (detect_sentiment,detect_pii_entities,detect_toxic_content) referenceself.comprehend_client, so they raisedAttributeError: 'ComprehendFilterAgent' object has no attribute 'comprehend_client'on the first request.Solution 1
Changed
self.client = boto3.client(...)toself.comprehend_client = boto3.client(...)in both branches of the else block, consistent with the existingoptions.clientpath.Problem 2 (fixes #360)
The
on_llm_startdocstring listed two incorrect parameters:agent_name(actual parameter isname) andmessages(not a parameter of this method at all).Solution 2
Updated the docstring to match the actual method signature: replaced
agent_namewithnameand removed the non-existentmessagesentry.