Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add knob throttle feature #178

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Conversation

hex-spell
Copy link

Add knob throttle feature

This fixes #176, the change is more noticeable in poly mode.
2023-09-25_22-21

@2xAA
Copy link
Owner

2xAA commented Dec 23, 2023

Hey @hex-spell, thanks for the contribution!
Though there's a few things I would like changed before merging this.

The major thing being that once the throttle is enabled, the UI update feels slow.
I would apply the throttle directly to the MIDI message output somehow instead of just the mouse move.

The throttle also doesn't apply to the DraggableSelect and MDMWaveform components, which can have the same issue as the MDMDial component as they have mouse inputs.

The import of lodash should be a named import (import { throttle } from "lodash";) to allow webpack to tree-shake the unused lodash modules from the resulting JavaScript bundle.

And lastly, the naming of "Knob Throttle". I'd prefer something like "Mouse Throttle" as it's only to do with the mouse input and should be applied to the MDMDial, DraggableSelect and MDMWaveform components.

@2xAA
Copy link
Owner

2xAA commented Dec 23, 2023

And also, once complete and explanation of the Mouse Throttle feature in the README would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Midi glitches when playing notes and turning knobs at the same time
2 participants