Skip to content

Conversation

@wonies
Copy link
Contributor

@wonies wonies commented Jan 15, 2025

📌 개요

  • ✨ [Feature] 모니터링스레드 - 42api/ 기간지난 이벤트 deactivate / slack봇 알람 기능 구현

💻 작업사항

  • 모니터링 스레드에서 42api를 통해 기존 event + 새로운 event 받아왔습니다
  • 모니터링 스레드에서 기간지난 이벤트를 activate -> deactivate 변경하는 로직 생성하였습니다
  • 모니터링 스레드에서 d-day, d-day-1 기간이 남은 스케줄에 한해서 slack 알람 기능 구현하였습니다.

✅ 변경로직

  • 기존 Retrieve로직에서 checkAuthor 부분때문에, 모니터링스레드에서 42api를 못받아오는 것을 확인하였습니다. 따라서, 조회로직에서 check하는 부분을 수정하였습니다

💡Issue 번호

@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 11.95652% with 81 lines in your changes missing coverage. Please review.

Please upload report for BASE (8th@7524677). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...r/api/user/utils/service/FortyTwoEventService.java 0.00% 32 Missing ⚠️
...ar/api/user/utils/service/ScheduleNotiService.java 0.00% 15 Missing ⚠️
...g-auth/src/main/java/gg/auth/FortyTwoAuthUtil.java 7.69% 12 Missing ⚠️
...api/user/utils/service/FortyTwoEventApiClient.java 0.00% 8 Missing ⚠️
...g/api/global/scheduler/CalendarEventScheduler.java 57.14% 6 Missing ⚠️
...r/api/user/utils/service/ScheduleCheckService.java 0.00% 4 Missing ⚠️
...utils/src/main/java/gg/utils/external/ApiUtil.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             8th    #1155   +/-   ##
======================================
  Coverage       ?   77.66%           
  Complexity     ?     1800           
======================================
  Files          ?      598           
  Lines          ?     8390           
  Branches       ?      539           
======================================
  Hits           ?     6516           
  Misses         ?     1623           
  Partials       ?      251           
Flag Coverage Δ
integrationTest 73.25% <9.78%> (?)
unitTest 29.46% <2.17%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taehyeon3 taehyeon3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seyeon22222 seyeon22222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@wonies wonies merged commit 5b9e049 into 8th Jan 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants