-
-
Notifications
You must be signed in to change notification settings - Fork 221
fix: TypeError in serializer for array with default value #1197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@janglad is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
franky47
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch, thanks! Yes it should definitely allow null values on properties to remove them.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
|
I need to work on the CI part of things to follow NPM's new security directives (OIDC trusted publishing), as they will deprecate long-lived deployment tokens soon, then this should be good to go live. Feel free to use the pkg.pr.new deployment if you want to use the hotfix in the mean time: pnpm add https://pkg.pr.new/nuqs@bec3404 |
|
🎉 This PR is included in version 2.7.3-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Previously
would throw when serialising with
{ arr : null }.From what I understand this should be allowed, and is indicated as such in the types. This was caused by the equality fn being called with null. This PR fixes this and adds a test to cover this case.