FacetList: Prevent scrolling when ExtendedDescriptionPopover is open#73
Open
alexkb0009 wants to merge 3 commits into
Open
FacetList: Prevent scrolling when ExtendedDescriptionPopover is open#73alexkb0009 wants to merge 3 commits into
alexkb0009 wants to merge 3 commits into
Conversation
Bianca-Morris
approved these changes
Jun 23, 2021
Bianca-Morris
left a comment
Bianca-Morris
left a comment
Contributor
There was a problem hiding this comment.
Code looks good to me. I'll probably test tomorrow and let you know how it goes.
utku-ozturk
approved these changes
Jun 23, 2021
Member
There was a problem hiding this comment.
I was not able to test it on 4DN since extended_descriptions are not supported yet. As far as I understand, I should test the following behavior on CGAP :) https://t.gyazo.com/teams/ff-4dn/033d1a8ebb20e7dc37ff57ddac519949.gif
The code looks and works great. IMHO, it is a good improvement in UX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Also has some minor cleanup+comments.)
Question alongside code review request is if you think it's worth having this at all (e.g. preventing vertical scrolling of both FacetList and body, of any of them, at all?)